JS: Fix inconsistencies in js/path-injection #3619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks great! Thanks for doing this. The new library looks great, but I'm also worried about diverging from the other language teams (who actually reached out to try and share theirs). I thought this was already linked to in https://github.com/github/codeql-javascript-team/issues/38 but it turns out I misread the comment from Esben. Sorry about that. I think it's fine to land this, just mentioning this before we pour more work into it. |
asgerf
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MembershipCandidatetojs/path-injection.BADtoGOOD(path.basename()andpath.extname()are safe).Consistency.qlto use a new consistency-checking library. (I've used this library to find other inconsistencies).The consistency-checking library works such that
Consistency.expectedshould always be empty.Known issues are marked with
[INCONSISTENCY], and the library then asserts the presence of an inconsistency at that location.TODO:
tainted-array-steps.jsstill contain 2 inconsistencies, becausejs/tainted-pathdoes not include array steps.