Sitelet https://web.archive.org/web/20200908194951/https://github.com/SforAiDl/genrl/issues/12
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policies #12

Open
Sharad24 opened this issue Mar 31, 2020 · 9 comments
Open

Policies #12

Sharad24 opened this issue Mar 31, 2020 · 9 comments

Comments

@Sharad24
Copy link
Member

@Sharad24 Sharad24 commented Mar 31, 2020 •

Add other basic policies such as

  • CNNPolicy (Nature CNN)
  • LSTMPolicy
  • CNNLstmPolicy (Nature CNN)
  • ImpalaCNNPolicy
  • ImpalaCNNLstmPolicy
@sampreet-arthi
Copy link
Member

@sampreet-arthi sampreet-arthi commented Apr 5, 2020

For a CNN Policy, since we will be mostly applying it for Gym Atari environments, would it be fine to take the settings as in the original DQN paper?

@Sharad24
Copy link
Member Author

@Sharad24 Sharad24 commented Apr 6, 2020

Yes. The architectures mentioned above are standard in RL

@Sharad24 Sharad24 mentioned this issue Apr 6, 2020
Closed
@Sharad24 Sharad24 added this to To do in Algorithms May 19, 2020
@Sharad24 Sharad24 removed this from To do in Project Structure May 19, 2020
@Sharad24
Copy link
Member Author

@Sharad24 Sharad24 commented Jul 18, 2020

@threewisemonkeys-as You were working on Impala right? Any chance we could fit some of it in here?

@threewisemonkeys-as
Copy link
Member

@threewisemonkeys-as threewisemonkeys-as commented Jul 19, 2020 •

I haven't added the CNN/LSTM policy to that yet, only built the actor / learner architecture so far with an Mlp policy here

Also what is the difference between Cnn LSTM (Nature) and IMPALA Cnn LSTM

@sampreet-arthi
Copy link
Member

@sampreet-arthi sampreet-arthi commented Jul 19, 2020

I don't think we need any LSTM policies right now? Impala CNN would be nice for Atari tho.

@hades-rp2010
Copy link
Contributor

@hades-rp2010 hades-rp2010 commented Jul 20, 2020

Can I take this up?
@sampreet-arthi said that there is support missing on the envs that require LSTM policies.. but still.. making it complete might help
Same for CNNLSTM.. Not sure if I can do the Impala ones tho

@Sharad24
Copy link
Member Author

@Sharad24 Sharad24 commented Jul 20, 2020

It might be a better idea to work on #194 first. After which new policies will be easy to add

@mehulrastogi
Copy link
Contributor

@mehulrastogi mehulrastogi commented Aug 12, 2020

Would just like to point out my comment in #222. Should we focus more on making policies easily extendible? Instead of adding multiple policies and passing string arguments for each policy?

@hades-rp2010
Copy link
Contributor

@hades-rp2010 hades-rp2010 commented Aug 12, 2020

I guess its already implemented in #205 with support for custom policies, values and actorcritics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Algorithms
  
To do
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.