I'd like to work on this if that's ok

Thanks for the interest @ammarnajjar, please go ahead if you'd like.
FTR, seems like 3.5's end of life is set to 2020-09-13, according to https://devguide.python.org/#status-of-python-branches

@elacuesta do you mean it would be better to wait till 3.5's EOL?

Not really, a patch should not be merged before that, but the work can start before.

#4324 is open, but I don't think it is a good idea to start that early, because of the merge conflicts along the way, I will suspend the work there on my side.

I think I have the solution
I have just refactored this function within the scrapy/core/spidermw.py file:

def _fname(f):
return "%s.%s".format(
f.self.class.name,
f.func.name
)

to fstrings with same placeholders, eg %s for strings,

def _fname(f):
return f"%s.%s"(
f.self.class.name,
f.func.name
)

Don't hurt me I am extremely newbie, I am only trying to help and gain experience.
Are there any other files within the scrapy source code that needs to be refactored or do I have to look through all of source code to find a way to use fstrings to refactor the code.

cheers danny

@ammarnajjar are you still working on this issue, if not I would like to work on it!

@joybhallaa , still 😄

Cool!

Is it possible for more than one person to work on this issue at the same time? I'm trying to find a way to contribute to OSS, but I'm having a hard time finding an entry point. This is something I could handle, though.

Should I start working on it? I see people working on it already. I hope it would be a good contribution to the community

@matthew02 @mHassan20896 there is a PR by @ammarnajjar which is a WIP(work in progress).

Can I start working on it?

@Grelo4ka #4324 (comment)

@Grelo4ka #4324 (comment)

Okay, in this case I'll try to find something else what I can work on

Can more than one person work on same issue, as this seems something i can start work from?

@Anupam-USP Two people working on it at the same time would, in my opinion, be a waste of time. Moreover, in this case there is already a good pull request, but until we decide to drop Python 3.5 support from Scrapy, I don’t think it makes sense for anyone to work on this further.

@Anupam-USP you can pick up other issues with the label good first issue
The maintainers and contributors are really helpful !