Sitelet https://web.archive.org/web/20201208041128/https://github.com/docker/getting-started/pull/47
Skip to content

/ getting-started

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .dockerignore for node_modules & explanation #47

Merged
merged 1 commit into from Jun 26, 2020
Merged

Add .dockerignore for node_modules & explanation #47

merged 1 commit into from Jun 26, 2020

Conversation

@dmahnkopf
Copy link
Contributor

@dmahnkopf dmahnkopf commented Jun 2, 2020

Fixes #46

Kindly requesting feedback 🙂
@dmahnkopf
Add .dockerignore for node_modules & explanation
fc90254
@StefanScherer
StefanScherer approved these changes Jun 26, 2020
View changes
Copy link
Member

@StefanScherer StefanScherer left a comment

Thank you very much @dmahnkopf! That is a good explanation with links for further information.

LGTM
@StefanScherer StefanScherer merged commit ef2a395 into docker:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanScherer StefanScherer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Add .dockerignore file for node_modules
2 participants
@dmahnkopf @StefanScherer
You can’t perform that action at this time.