Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uppatch review prototype #935
Conversation
|
Thanks for the video @vilmibm, it was great to hear your thoughts while seeing the prototype in action. This works better than I expected it to! Below are some thoughts I had while watching this:
|
|
Loved the video demo! I can see that this was modelled after What I find missing from this concept is a fleshed-out way for commenting on a specific line (or a set of lines). Furthermore, I think that a code review tool should allow adding comments specifically on either added lines (right side of split diff) or removed lines (left side of split diff). From your prototype, it looks like it's only possible to comment on whole chunks of diff. Did you have a vision on how to enable more precise targeting for comments? I second all @probablycorey's points; I think you did explain what is the use-case for Overall, I feel that this style of interaction is promising and I'd be interested in adding it to our roadmap. |
vilmibm commentedMay 15, 2020
•
edited
NARRATED VIDEO DEMO: https://www.youtube.com/watch?v=LFeuKxolMUg
This PR is a prototype of a "patch mode" approach to reviewing. You can
gh pr checkoutthis andrun it with
gh pr review -p 123. It will never try to post an actual review.What functions in the prototype:
what is mocked but not functioning:
what is not mocked but part of the idea:
I'm curious if people have any feedback, up to and including whether or not this is worth fleshing
out more and putting on a roadmap.
(It hopefully goes without saying that the code is a nightmare and very little of it should ever actually be merged)