Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Mark EVM instruction `pc()` as deprecated when used in inline assembly. #8913
Conversation
|
Please remove PCFinder. |
|
And of course the failing tests. |
ae75ad8
to
7c4c574
test/libyul/yulOptimizerTests/fullSuite/stack_compressor_msize.yul
Outdated
Show resolved
Hide resolved
test/libyul/yulOptimizerTests/fullSuite/stack_compressor_msize.yul
Outdated
Show resolved
Hide resolved
Changelog.md
Outdated
| @@ -29,6 +29,7 @@ Important Bugfixes: | |||
|
|
|||
| Language Features: | |||
| * Implemented ``type(T).min`` and ``type(T).max`` for every integer type ``T`` that returns the smallest and largest value representable by the type. | |||
| * Yul: EVM instruction `pc()` is marked deprecated and will be removed in the next breaking release. | |||
chriseth
May 27, 2020
Contributor
This is in the wrong release.
This is in the wrong release.
|
Update changelog. |
afa873f
into
develop
7 of 21 checks passed
7 of 21 checks passed
| @@ -6,7 +6,6 @@ | |||
| pop(extcodehash(0)) | |||
| pop(returndatasize()) | |||
| pop(sload(0)) | |||
| pop(pc()) | |||
axic
May 27, 2020
Member
Why was this and the test above removed? It is deprecated but still has to produce proper code.
Why was this and the test above removed? It is deprecated but still has to produce proper code.
christianparpart
May 27, 2020
Author
Member
It's a warning now but going to be removed in the next breaking release, which is about to be soon(?).
It's a warning now but going to be removed in the next breaking release, which is about to be soon(?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
References #7965.
It only marks
pc()as deprecated.