Sitelet https://web.archive.org/web/20221223113512/https://github.com/python/cpython/pull/19385
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40174: Check when clock_gettime is necessary #19385

Closed
wants to merge 1 commit into from
Closed

bpo-40174: Check when clock_gettime is necessary #19385

wants to merge 1 commit into from

Conversation

Jerome-PS
Copy link

@Jerome-PS Jerome-PS commented Apr 5, 2020 •
edited by bedevere-bot

Detect and announces cases when clock_gettime is necessary but not found.

https://bugs.python.org/issue40174

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Apr 5, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Jerome-PS

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

vstinner
vstinner reviewed Apr 8, 2020
View changes
Copy link
Member

@vstinner vstinner left a comment

I would prefer to require clock_gettime in pytime.c. I dislike having to keep configure.ac and pytime.c in sync.

@csabella
Copy link
Contributor

csabella commented Jul 20, 2020

@Jerome-PS, please sign the CLA as requested above. Without a signed CLA, this PR will be closed.

@csabella csabella added the stale Stale PR or inactive for long period of time. label Jul 20, 2020
@Jerome-PS
Copy link
Author

Jerome-PS commented Jul 20, 2020

@Jerome-PS, please sign the CLA as requested above. Without a signed CLA, this PR will be closed.

Well, I DID sign it!

@csabella csabella removed CLA not signed stale Stale PR or inactive for long period of time. labels Jul 24, 2020
@iritkatriel
Copy link
Member

iritkatriel commented Apr 11, 2022

https://bugs.python.org/issue40174 is closed. What is the status of this PR?

@vstinner
Copy link
Member

vstinner commented Apr 19, 2022

No activity for 2 years, the associated issue is closed, I close this PR.

@vstinner vstinner closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Jerome-PS @the-knights-who-say-ni @csabella @iritkatriel @vstinner @bedevere-bot