Sitelet https://web.archive.org/web/20200413160812/https://github.com/EFForg/https-everywhere/issues/18877
Skip to content

/ https-everywhere

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vitalwerks.xml no-ip.com suspect regex #18877

Open
jayvdb opened this issue Feb 9, 2020 · 1 comment
Open

Vitalwerks.xml no-ip.com suspect regex #18877

jayvdb opened this issue Feb 9, 2020 · 1 comment
Assignees
@pipboy96
Labels
ruleset-bug

Comments

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Feb 9, 2020

Type: ruleset/website issue

Domain: no-ip.com

215702b added this rule, and it contains regex snippet [^$] which I believe always means 'a char, except literal $'. I assume what was intended was 'not end of URL', which is almost the same thing, however . would have achieved that more simply.

> r = RegExp('a[^$]')
/a[^$]/
> 'aa'.match(r)
[ 'aa', index: 0, input: 'aa' ]
> 'a$'.match(r)
null
@pipboy96 pipboy96 self-assigned this Feb 9, 2020
@jayvdb

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@jayvdb jayvdb commented Apr 11, 2020 •
edited

(btw, I confirmed that the [^$] is illogical regex here, so I dont think more info is required.)

https://www.noip.com/company redirects to https://www.noip.com/about

https://www.noip.com/clients is 404

newUser is replaced by https://www.noip.com/sign-up

Basically, this rule is broken.

And in addition, it has a s3 rule.

#17912
jayvdb added a commit to jayvdb/https-everywhere that referenced this issue Apr 11, 2020
@jayvdb
Vitalwerks.xml: Simplify outdated rules
4f687a4 
`[^$]` was invalid syntax, and the paths given no longer exist.

Also amazon will stop working soon.

Fixes EFForg#18877
@jayvdb jayvdb mentioned this issue Apr 11, 2020
Open
jayvdb added a commit to jayvdb/https-everywhere that referenced this issue Apr 11, 2020
@jayvdb
Vitalwerks.xml: Simplify outdated rules
be94afc 
`[^$]` was invalid syntax, and the paths given no longer exist.

Also amazon will stop working soon.

Fixes EFForg#18877
jayvdb added a commit to jayvdb/https-everywhere that referenced this issue Apr 11, 2020
@jayvdb
Vitalwerks.xml: Simplify outdated rules
a5fc70b 
`[^$]` was invalid syntax, and the paths given no longer exist.

Also amazon will stop working soon.

Fixes EFForg#18877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pipboy96 pipboy96

Labels
ruleset-bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jayvdb @pipboy96
You can’t perform that action at this time.