Sitelet https://web.archive.org/web/20251226212650/https://github.com/github/vscode-codeql/pull/324
Skip to content

Conversation

@jcreedcmu
Copy link
Contributor

Fixes #323.

cc: @github/product-docs-dsp in case this needs docs.

@jcreedcmu jcreedcmu requested review from abenapraba, aeisenberg and p0 and removed request for abenapraba April 2, 2020 17:26
@shati-patel
Copy link
Contributor

cc: @github/product-docs-dsp in case this needs docs.

Thank you for the mention! Just a changelog entry should be fine in this case.

@jcreedcmu
Copy link
Contributor Author

Not sure why unit tests are timing out on windows only.

@jcreedcmu jcreedcmu force-pushed the jcreed/always-save branch from 1de3539 to 0307447 Compare April 3, 2020 13:10
@jcreedcmu
Copy link
Contributor Author

Tests weren't running on windows because codeql the shell script (or possibly codeql.cmd) was overwriting codeql.exe the binary during unzipping --- implying, I think, correct me if I'm wrong, that it's specficially unzip which is making this call as to which files are morally the same as one another, not the underlying filesystem.

@jcreedcmu jcreedcmu force-pushed the jcreed/always-save branch from db3f310 to 171d430 Compare April 7, 2020 14:07
@jcreedcmu jcreedcmu force-pushed the jcreed/always-save branch from 171d430 to e5305ab Compare April 7, 2020 16:02
@jcreedcmu jcreedcmu merged commit e4df717 into github:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running an unsaved query should have 'always save' choice

3 participants