Sitelet https://web.archive.org/web/20191208060933/https://github.com/angular/angular/pull/33584
Skip to content

/angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): update CLDR generated files #33584

Closed
wants to merge 2 commits into from
+4,197 −2,695

Conversation

@josephperrott
Copy link
Member

josephperrott commented Nov 4, 2019

No description provided.

@googlebot googlebot added the cla: yes label Nov 4, 2019
@josephperrott josephperrott force-pushed the josephperrott:cldr branch 7 times, most recently from 278fbe2 to 6b3dba3 Nov 4, 2019
@gkalpak
gkalpak reviewed Nov 5, 2019
View changes
.circleci/config.yml Outdated Show resolved Hide resolved
tools/gulp-tasks/cldr/extract.js Outdated
@@ -519,7 +519,7 @@ function getPluralFunction(locale) {

fn = fn
.replace(
toRegExp('function anonymous(n\n/*``*/) {\n'),
toRegExp('function anonymous\(n\n\) {\n'),

This comment has been minimized.

Sign in to view
Copy link
@gkalpak

gkalpak Nov 5, 2019

Member

Escaping ( and ) is handled by isRegExp(), so it shouldn't be necessary.
@josephperrott josephperrott force-pushed the josephperrott:cldr branch 4 times, most recently from 5e9dc25 to 68c7c7c Nov 5, 2019
@ngbot ngbot bot added this to the needsTriage milestone Nov 5, 2019
@josephperrott josephperrott marked this pull request as ready for review Nov 5, 2019
@josephperrott josephperrott requested review from angular/dev-infra-framework as code owners Nov 5, 2019
@clydin

This comment has been minimized.

Sign in to view
Copy link
Member

clydin commented Nov 6, 2019

Can you add the CLDR version into the commit message? The large volume of changes makes it hard to find what version is being used.
@petebacondarwin
petebacondarwin approved these changes Nov 6, 2019
View changes
Copy link
Member

petebacondarwin left a comment •
edited

@josephperrott - can the first commit message be

build: update CLDR version to v33

Also can you explain what you did in the final fixup commit that changes \u202f strings, and why?
@petebacondarwin petebacondarwin mentioned this pull request Nov 6, 2019
Closed
4 of 14 tasks complete
@josephperrott josephperrott force-pushed the josephperrott:cldr branch from 68c7c7c to b45e59c Nov 6, 2019
@josephperrott

This comment has been minimized.

Sign in to view
Copy link
Member Author

josephperrott commented Nov 6, 2019

Updated the commit messages to include the CLDR version.

@petebacondarwin I don't know what I did that ended up removing them, but that was the wrong thing since those strings should be there.
@petebacondarwin
petebacondarwin approved these changes Nov 6, 2019
View changes
@josephperrott josephperrott force-pushed the josephperrott:cldr branch from b45e59c to ed7c642 Nov 6, 2019
@josephperrott josephperrott force-pushed the josephperrott:cldr branch 4 times, most recently from cee8b75 to ba24666 Nov 7, 2019
@josephperrott josephperrott force-pushed the josephperrott:cldr branch from ba24666 to d148d11 Nov 7, 2019
@josephperrott
build: update cldr-data package to 36.0.0
Loading status checks…
522bb36
@josephperrott josephperrott force-pushed the josephperrott:cldr branch from d148d11 to 18cd7be Nov 7, 2019
@josephperrott
fix(common): update CLDR generated files to 36.0.0
Loading status checks…
3b9d51c
@josephperrott josephperrott force-pushed the josephperrott:cldr branch from 18cd7be to 3b9d51c Nov 7, 2019
@atscott atscott closed this in e51acd5 Nov 7, 2019
atscott added a commit that referenced this pull request Nov 7, 2019
@josephperrott @atscott
fix(common): update CLDR generated files to 36.0.0 (#33584)
Loading status checks…
c77faf5 
PR Close #33584
atscott added a commit that referenced this pull request Nov 7, 2019
@josephperrott @atscott
build: update cldr-data package to 36.0.0 (#33584)
0248d6b 
PR Close #33584
atscott added a commit that referenced this pull request Nov 7, 2019
@josephperrott @atscott
fix(common): update CLDR generated files to 36.0.0 (#33584)
Loading status checks…
c1bd3bc 
PR Close #33584
@doom777

This comment has been minimized.

Sign in to view
Copy link
Contributor

doom777 commented Nov 7, 2019

forgot to remove the old cldr-data directory from .gitignore.
I'll remove it in my PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkalpak gkalpak

@petebacondarwin petebacondarwin

@angular/fw-core fw-core

@angular/dev-infra-framework dev-infra-framework

@IgorMinar IgorMinar

@clydin clydin

Assignees
No one assigned
Labels
PR action: merge PR target: master & patch cla: yes comp: build & ci comp: common
Projects
None yet
Milestone
  needsTriage
7 participants
@josephperrott @clydin @doom777 @petebacondarwin @gkalpak @atscott @googlebot
You can’t perform that action at this time.