Sitelet https://web.archive.org/web/20210210085324/https://github.com/github/gitignore/pull/3291
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Reason.gitignore option #3291

Open
wants to merge 2 commits into
base: master
from
Open

add Reason.gitignore option #3291

wants to merge 2 commits into from

Conversation

@idkjs
Copy link

@idkjs idkjs commented Jan 19, 2020

Reasons for making this change:

Adding ReasonML .gitignore option to Desktop new repository workflow. Currently there is no reasonml .gitignore option. Here are the options under languages that start with the letter R for the .gitignore menu. These are the current options for the letter R:

Screenshot 2020-01-19 at 9 00 16 AM

This would add a .gitignore option for a recognized github language.

This template is the .gitignore that comes from the ReasonML/Bucklescript react template which might serve as a base.

.DS_Store
.merlin
.bsb.lock
npm-debug.log
/lib/bs/
/node_modules/

If this is a new template:

@Et7f3
Copy link

@Et7f3 Et7f3 commented Jan 19, 2020 •

Can you add _esy and _build. It is created when we do native.
You can use https://github.com/github/gitignore/blob/master/OCaml.gitignore in the meantime.

@idkjs
Copy link
Author

@idkjs idkjs commented Jan 19, 2020

Done. Comments?

@Et7f3
Copy link

@Et7f3 Et7f3 commented Jan 19, 2020 •

Can you make your change to OCaml.gitignore and symlink it because they have the same trash files. Like Kotlin and Java.

@idkjs
Copy link
Author

@idkjs idkjs commented Jan 19, 2020

Will have to look up symlinking on a git pull. Otherwise, if you think that is best, works for me.

@@ -0,0 +1,15 @@
# other
.DS_Store

This comment has been minimized.

@Hipska

Hipska Aug 21, 2020

This is already present in macOS.gitignore:

.DS_Store

# node
npm-debug.log

This comment has been minimized.

@Hipska

Hipska Aug 21, 2020

This is already present in Node.gitignore:

# Logs
logs
*.log
npm-debug.log*


# node
npm-debug.log
/node_modules/

This comment has been minimized.

@Hipska

Hipska Aug 21, 2020

This is already present in Node.gitignore:

gitignore/Node.gitignore

Lines 40 to 42 in 218a941

# Dependency directories
node_modules/
jspm_packages/

This comment has been minimized.

@Et7f3

Et7f3 Aug 22, 2020 •

Can we somehow merge gitignore because reason in itself is just a syntax that can use native tool of ocaml (ocaml.gitgnore) or js tools when target web (Node.gitignore) or maybe shall we create ReasonNative.gitignore and ReasonNode.gitignore
(Also their is a rebranding now Reason targeted at js is ReScript-lang) and ReasonMl focus on native side.

Maybe something like c preproccessor (with other marker because it is for comment)
#include "tools/opam.gitgnore"
#include "tools/esy.gitgnore"

(opam/esy is just like npm/yarn it depends of what we like)

#include "os/window.gitignore"
#include "os/macOs.gitignore"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants