Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRandom failures in CrawlTestCase.test_fixed_delay #4268
Comments
This comment has been minimized.
This comment has been minimized.
|
Hey, can I work on this ? |
This comment has been minimized.
This comment has been minimized.
|
@joybhallaa sure! |
This comment has been minimized.
This comment has been minimized.
|
Hey, @joybhallaa you still working on it? If not @Gallaecio can I try it? |
This comment has been minimized.
This comment has been minimized.
|
@globefire, sure ! |
This comment has been minimized.
This comment has been minimized.
|
@wRAR can i work on this issue ? |
This comment has been minimized.
This comment has been minimized.
|
@sakshamb2113 sure |
This comment has been minimized.
This comment has been minimized.
|
@wRAR I looked at the PR you made recently where there is a similar error as you described above for pypy3 tox env . Does this error always come up for pypy3 only? |
This comment has been minimized.
This comment has been minimized.
|
@sakshamb2113 it's not similar at all. |
This comment has been minimized.
This comment has been minimized.
|
@sakshamb2113 or do you mean #4367? Even there a similar error also happened for the |
This comment has been minimized.
This comment has been minimized.
|
@wRAR I ran test_crawl.py a number of times on py3 and flake8 on local machine but was not able to reproduce this error even for total and delay variables both equal to zero. That should mean that this error arises only when tests run on travis ci and has something to do with the environment variables there. |
This comment has been minimized.
This comment has been minimized.
|
@sakshamb2113 I had this error locally. |
This comment has been minimized.
This comment has been minimized.
|
It should be a “simple” matter of increasing the parameters of the corresponding tests, using the minimum values that do not cause the tests to fail. |
This comment has been minimized.
This comment has been minimized.
|
I was able to obtain the error locally after which I changed the "total" parameter from 3 to 4 and ran the tests.I have not obtained any error until now. |
This comment has been minimized.
This comment has been minimized.
|
@Gallaecio @wRAR Should we change the "delay" parameter from 0.1 to 0.11 (I got no error for delay=0.11 in 80 test runs) ? |
This comment has been minimized.
This comment has been minimized.
|
@wRAR Can you check if that also works for you? If so, I guess it makes sense for @sakshamb2113 to create a pull request with the change, and we can see if the PyPy Travis CI job also works, and we can hope it will continue to work after we merge. |
On some test runs
CrawlTestCase.test_fixed_delayfails with