Sitelet https://web.archive.org/web/20200715015710/https://github.com/magento/magento2/issues/26288
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing Throw in copy pasted code #26288

Open
angelomaragna opened this issue Jan 7, 2020 · 7 comments · May be fixed by #27269
Open

missing Throw in copy pasted code #26288

angelomaragna opened this issue Jan 7, 2020 · 7 comments · May be fixed by #27269

Comments

@angelomaragna
Copy link
Contributor

@angelomaragna angelomaragna commented Jan 7, 2020 •

Preconditions (*)
magento 2.3.3

Steps to reproduce (*)
go to /Magento/Customer/Model/ForgotPasswordToken/GetCustomerByToken.php of magento installation

Expected result (*)
exception should be covered with throw

Actual result (*)
Hi, you've got a problem with file https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Customer/Model/ForgotPasswordToken/GetCustomerByToken.php

image

Check this pull request if you wish: #26287

@m2-assistant
Copy link

@m2-assistant m2-assistant bot commented Jan 7, 2020

Hi @angelomaragna. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@angelomaragna do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@m2-assistant
Copy link

@m2-assistant m2-assistant bot commented Jan 8, 2020

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@magento-engcom-team
Copy link
Contributor

@magento-engcom-team magento-engcom-team commented Jan 9, 2020

@shikhamis11 Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team
Copy link
Contributor

@magento-engcom-team magento-engcom-team commented Jan 9, 2020

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MC-30309 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-assistant
Copy link

@m2-assistant m2-assistant bot commented Jan 17, 2020

Hi @shubhamkhandelwalrtpl. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


shubhamkhandelwalrtpl added a commit to shubhamkhandelwalrtpl/magento2 that referenced this issue Jan 18, 2020
@GovindaSharma GovindaSharma self-assigned this Jan 27, 2020
@m2-assistant
Copy link

@m2-assistant m2-assistant bot commented Jan 27, 2020

Hi @GovindaSharma. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


Bal2018 added a commit to Bal2018/magento2 that referenced this issue Mar 12, 2020
@Bal2018 Bal2018 linked a pull request that will close this issue Mar 12, 2020
0 of 4 tasks complete
Bal2018 added a commit to Bal2018/magento2 that referenced this issue Mar 13, 2020
@magento-engcom-team magento-engcom-team added this to PR In Progress in Community Backlog Mar 24, 2020
@m2-backlog m2-backlog bot moved this from PR In Progress to Dev in Progress in Community Backlog Jun 26, 2020
@m2-backlog m2-backlog bot moved this from Dev in Progress to PR In Progress in Community Backlog Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.