Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 40 million developers.
Sign up
Pro
-
Microsoft
-
Microsoft
Pinned
4,479 contributions in the last year
Activity overview
Contribution activity
September 2019
Created a pull request in dotnet/corefx that received 11 comments
Move XLinq specific type description providers into its assembly
Avoids cross-assembly private reflection. @ericstj, does this cause any cyclic problems or anything like that? I'm suspicious that it wasn't done t…
+12
−9
•
11
comments
- Remove some unnecessary string concatenation from CertificatePal.AppendPrivateKeyInfo
- Annotate System.Threading.Tasks.Parallel for nullability
- Enable better trimming of derived XmlReader/Writer-derived types
- Remove unused StringExtensions.cs from a couple projects
- Fix trimming of System.Net.NetworkInformation
- Fix trimming of System.Net.Ping
- Remove DEBUG-only TraceSource/Switch usage from corefx
- Use HashCode instead of HashHelpers in netstandard libs
- Remove unused files from System.Net.Http
- Remove use of RuntimeReflectionExtensions from Microsoft.CSharp
- Remove use of non-generic Queue/Stack in System.Private.Xml
- Remove System.Net.Requests dependency from System.Private.Xml
- Remove System.Net.Http dependency on System.Text.RegularExpressions
- Remove unnecessary passing of RegexOptions.None to Regex ctor
- Enable Regex compiler to be trimmed
- Remove allocations from Dns.*
- Fix namespace typo in Tasks test
- Allow more of ConsolePal to be linked away
- Replace HashHelpers.Combine with HashCode.Combine in netcoreapp projects
- Make "remote" more CultureInfo.CurrentCulture setting tests
- Fix some low-hanging fruit boxing in JsonSerializer
- [release/3.0] Allow NetworkStream.WriteAsync calls to be canceled asynchronously
- Allow NetworkStream.WriteAsync calls to be canceled asynchronously
- Reduce number of PFX loads in System.Net tests
- Remove reflection from ThreadPoolHelpers test class
- Some pull requests not shown.
- More Corelib cleanup
- Change several internal/private instance methods to be static
- Delete CommonlyUsedGenericInstantiations
- Remove Lazy/LazyInitializer from mscorlib.h
- Remove remaining String.ToLower() use from corelib
- Remove sub-array allocation from GetManifestResourceNamesList
- Remove fcall duplication with {Try}EnsureSufficientExecutionStack
- Remove use of non-generic WeakReference from corelib
- Replace HashHelpers.Combine with HashCode.Combine
- Remove some boxing from tuples with >= 8 elements
- Fix race conditions in CultureInfo.GetCultureInfoHelper
- More in-between meetings style cleanup
- Fix StyleCop tuple warnings
- Restore partial Corelib build support in VS
- Remove `readonly` from GCHandle field on Gen2GcCallback
- Remove stale SuppressMessage attributes
- Use expression-bodied members in more places
- Update StyleCop.Analyzers to same version used by corefx
- Remove unnecessary parens from `return (true);` and `return (false);`
- Avoid some unnecessary initialization in DateTimeParse
- Add CollectionsMarshal ref assemblies
- improve stability of FileSystemWatcher tests
- HTTP2: Support receiving dynamic table headers
- Exploration: Retry STATUS_UNSUCCESSFUL from CNG
- Fixing outdated method name
- Replace RS4 with Client19H1 in CI
- Add more Unicode validation tests
- Fix validity encoding for cert dates after 2049
- Remove person who left the company
- Socket: don't perform RST close on Dispose when user called Shutdown
- Public static fields should require no suffix
- Use slow path for CallInstruction returning enum value #40976
- Annotate System.Diagnostics.DiagnosticSource for nullable
- Implement FromOid and TryFromOid.
- HttpClientHandler functional test: replace remote server dependency
- Improve test coverage for Span-based globalization APIs
- Additional enum tests for System.Linq.Expressions.Interpreter.CallInstruction
- Port: Fix icon entry selection (#41048)
- Support PAC scripts that return multiple proxies
- Annotate System.ComponentModel.Primitives for nullable
- Annotate System.Collections.Specialized for nullable
- Enable nullable annotations for System.Drawing.Primitives
- Fix DeflateStream.CopyTo for concatenated payloads
- Fix the filename used by the VerifyCrlCache test
- improve span.StartsWith(span) test coverage
- Some pull request reviews not shown.
- Remove IsFastSort optimizations from String
- Delete unused .idl files
- Fix calendar instance inside the culture after cloning
- Fixing a simple typo
- Improve the performance of Environment.WorkingSet in Windows
- Fix Running .NET Core Under Windows App Compat Shim
- Remove use of non-generic WeakReference from corelib
- Move TypedReference::SetTypedReference exception throw to managed
- Remove unused Memcpy methods from shared Buffer implementation
- Make StringComparer.Create throw ArgumentNullException
- Remove unnecessary !s for [DoesNotReturn]
- Refactor BinaryReader.ReadChars using Span
- Conditionally remove the GC transition from a P/Invoke
Created an issue in dotnet/corefx that received 25 comments
Static analysis for .NET 5
In FxCop's hey day, many rules were written to help validate the correctness and performance of .NET code. .NET has evolved significantly since the…
•
25
comments
- Remove dependencies on System.ComponentModel.TypeConverter.dll
- Find a way to trim out ExcludeFromCodeCoverage attribute from published trimmed app
- Address SqlXml to CreateSqlReader dependency for assembly size
- XmlSerializer.GenerateSerializer should not be in System.Private.Xml
- Consider PreserveDependencyAttribute to help linker
- Remove CurlHandler fallback from HttpClientHandler
- Remove WinHttpHandler fallback from HttpClientHandler
- AttributeArray_SetGetAttributesAndModify_DoesCopy failed in CI
- Message_ShouldFormatCountOfRootCausesUsingTheCurrentCulture test failed in CI on UAP
- GetInstance_ExpectedCurrent_ReturnsExpected failed in CI on uap
- CultureInfo.ClearCachedData may not fully clear if called concurrently with GetCultureInfo
- RemoteExecutor.Invoke incurs large overheads with checked coreclr
- Several Outerloop System.Net.Socket tests broken by TcpClient change
- AsymmetricEncryptionRoundtrip(useOAEP: False) test failed
- IDE0018 preview presents incorrect option if blank line present
- IDE0018 removes necessary nullable annotations
- IDE1006 doesn't provide a "fix all"?
- [MaybeNullWhen(false)] results in disagreement between IntelliSense and compiler
- Auto-completion initializing nullable local creates invalid code
- IDE0059 has misleading auto-fix name / incorrect preview with unnecessary ??= assignment
- IDE0041 only offers `is null` when there's a cast
1
contribution
in private repositories
Sep 20