Sitelet https://web.archive.org/web/20200930195305/https://github.com/dotnet/runtime/pull/94
Skip to content

/ runtime

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows support for build.sh #94

Merged
merged 1 commit into from Nov 18, 2019
Merged

Add windows support for build.sh #94

merged 1 commit into from Nov 18, 2019

Conversation

@eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Nov 18, 2019

Ports the change from dotnet/corefx#41947
@eiriktsarpalis
Add windows support for build.sh
Loading status checks…
628076c
@eiriktsarpalis eiriktsarpalis requested a review from ViktorHofer Nov 18, 2019
@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 18, 2019 •
edited

I assume we only need this in the root script and not in the helper ones? Ie libraries.sh.
@ViktorHofer
ViktorHofer approved these changes Nov 18, 2019
View changes
@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 18, 2019

This will never be exercised in CI so please make sure it works correctly. Also expect this to be broken if someones changes the scripts as some point.
@eiriktsarpalis
Copy link
Member Author

@eiriktsarpalis eiriktsarpalis commented Nov 18, 2019

This will never be exercised in CI so please make sure it works correctly.

This has been soaked in corefx for a few months, so I'm expecting it to work without issue.
@eiriktsarpalis
Copy link
Member Author

@eiriktsarpalis eiriktsarpalis commented Nov 18, 2019 •
edited

I assume we only need this in the root script and not in the helper ones? Ie libraries.sh.

Good question. I think it's generally overkill to do it everywhere. It's best to just keep it in common entrypoints, given that our bash infra won't support windows in the foreseeable future.
@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Nov 18, 2019

Merging as we passed the stage where build.cmd/sh is called.
@ViktorHofer ViktorHofer merged commit 7783fd5 into dotnet:master Nov 18, 2019
52 of 61 checks passed
52 of 61 checks passed
runtime-installer Build #20191118.6 failed
Details
runtime-installer (Build Windows_Arm debug) Build Windows_Arm debug failed
Details
runtime-installer (Build Windows_Arm release) Build Windows_Arm release failed
Details
runtime-installer (Build Windows_Arm64 debug) Build Windows_Arm64 debug failed
Details
runtime-installer (Build Windows_Arm64 release) Build Windows_Arm64 release failed
Details
runtime-installer (Build Windows_x64 debug) Build Windows_x64 debug failed
Details
runtime-installer (Build Windows_x64 release) Build Windows_x64 release failed
Details
runtime-installer (Build Windows_x86 debug) Build Windows_x86 debug failed
Details
runtime-installer (Build Windows_x86 release) Build Windows_x86 release was canceled
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
runtime-coreclr Build #20191118.9 succeeded
Details
runtime-coreclr (Build Linux arm checked) Build Linux arm checked succeeded
Details
runtime-coreclr (Build Linux arm64 checked) Build Linux arm64 checked succeeded
Details
runtime-coreclr (Build Linux arm64 release) Build Linux arm64 release succeeded
Details
runtime-coreclr (Build Linux x64 checked) Build Linux x64 checked succeeded
Details
runtime-coreclr (Build Linux_musl x64 checked) Build Linux_musl x64 checked succeeded
Details
runtime-coreclr (Build Linux_musl x64 release) Build Linux_musl x64 release succeeded
Details
runtime-coreclr (Build Linux_rhel6 x64 release) Build Linux_rhel6 x64 release succeeded
Details
runtime-coreclr (Build OSX x64 checked) Build OSX x64 checked succeeded
Details
runtime-coreclr (Build OSX x64 release) Build OSX x64 release succeeded
Details
runtime-coreclr (Build Windows_NT arm checked) Build Windows_NT arm checked succeeded
Details
runtime-coreclr (Build Windows_NT arm release) Build Windows_NT arm release succeeded
Details
runtime-coreclr (Build Windows_NT arm64 checked) Build Windows_NT arm64 checked succeeded
Details
runtime-coreclr (Build Windows_NT arm64 release) Build Windows_NT arm64 release succeeded
Details
runtime-coreclr (Build Windows_NT x64 checked) Build Windows_NT x64 checked succeeded
Details
runtime-coreclr (Build Windows_NT x64 debug) Build Windows_NT x64 debug succeeded
Details
runtime-coreclr (Build Windows_NT x64 release) Build Windows_NT x64 release succeeded
Details
runtime-coreclr (Build Windows_NT x86 checked) Build Windows_NT x86 checked succeeded
Details
runtime-coreclr (Build Windows_NT x86 debug) Build Windows_NT x86 debug succeeded
Details
runtime-coreclr (Checkout (Unix)) Checkout (Unix) succeeded
Details
runtime-coreclr (Checkout (Windows)) Checkout (Windows) succeeded
Details
runtime-coreclr (Formatting Linux x64) Formatting Linux x64 succeeded
Details
runtime-coreclr (Formatting Windows_NT x64) Formatting Windows_NT x64 succeeded
Details
runtime-installer (Build Linux_Arm debug) Build Linux_Arm debug succeeded
Details
runtime-installer (Build Linux_Arm release) Build Linux_Arm release succeeded
Details
runtime-installer (Build Linux_Arm64 debug) Build Linux_Arm64 debug succeeded
Details
runtime-installer (Build Linux_Arm64 release) Build Linux_Arm64 release succeeded
Details
runtime-installer (Build Linux_Arm64_Alpine37 debug) Build Linux_Arm64_Alpine37 debug succeeded
Details
runtime-installer (Build Linux_Arm64_Alpine37 release) Build Linux_Arm64_Alpine37 release succeeded
Details
runtime-installer (Build Linux_x64_Alpine39 debug) Build Linux_x64_Alpine39 debug succeeded
Details
runtime-installer (Build Linux_x64_Alpine39 release) Build Linux_x64_Alpine39 release succeeded
Details
runtime-installer (Build Linux_x64_Rhel6 debug) Build Linux_x64_Rhel6 debug succeeded
Details
runtime-installer (Build Linux_x64_Rhel6 release) Build Linux_x64_Rhel6 release succeeded
Details
runtime-installer (Build Linux_x64_glibc debug) Build Linux_x64_glibc debug succeeded
Details
runtime-installer (Build Linux_x64_glibc release) Build Linux_x64_glibc release succeeded
Details
runtime-installer (Build OSX debug) Build OSX debug succeeded
Details
runtime-installer (Build OSX release) Build OSX release succeeded
Details
runtime-libraries Build #20191118.3 succeeded
Details
runtime-libraries (Linux Build RedHat6_x64_Release) Linux Build RedHat6_x64_Release succeeded
Details
runtime-libraries (Linux Build arm64_Debug) Linux Build arm64_Debug succeeded
Details
runtime-libraries (Linux Build arm_Debug) Linux Build arm_Debug succeeded
Details
runtime-libraries (Linux Build musl_arm64_Debug) Linux Build musl_arm64_Debug succeeded
Details
runtime-libraries (Linux Build musl_x64_Debug) Linux Build musl_x64_Debug succeeded
Details
runtime-libraries (Linux Build wasm_Release) Linux Build wasm_Release succeeded
Details
runtime-libraries (Linux Build x64_Debug) Linux Build x64_Debug succeeded
Details
runtime-libraries (MacOS Build x64_Debug) MacOS Build x64_Debug succeeded
Details
runtime-libraries (Windows Build NETFX_x86_Release) Windows Build NETFX_x86_Release succeeded
Details
runtime-libraries (Windows Build x64_Debug) Windows Build x64_Debug succeeded
Details
runtime-libraries (Windows Build x86_Release) Windows Build x86_Release succeeded
Details
runtime-libraries (Windows Packaging All Configurations x64_Debug) Windows Packaging All Configurations x64_Debug succeeded
Details
@ViktorHofer ViktorHofer deleted the eiriktsarpalis:build-sh-add-cygwin-support branch Nov 18, 2019
eiriktsarpalis added a commit that referenced this pull request Apr 6, 2020
@eiriktsarpalis
Revert "Add windows support for build.sh (#94)"
933056c 
This reverts commit 7783fd5.
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
5.0.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@eiriktsarpalis @ViktorHofer @karelz
You can’t perform that action at this time.