@ivanwonder, you are correct. The TemplateAst parser does not parse attributes correctly. This is bad, because it means there's no 1-1 mapping from HtmlAst to TemplateAst.
More specifically, the HtmlAst would contain Element --> Attribute, but when it gets parsed into TemplateAst, there's only ElementAst. This is why the visit has no effect.
I'll fix this in a separate PR, and you should be able to implement this feature the correct way after that.
Thank you for your patience!

Thank you for your guidance. I will pick it up after you fix the problem.

@kyliau I think I can help to resolve the problem of TemplateAst if you have not begun to do it or no time to look into it.
I recently read the code, and my solution is to add the reference to the array targetReferences before reporting the error on line 596.

@kyliau I think I can help to resolve the problem of TemplateAst if you have not begun to do it or no time to look into it.

I think this was partially fixed in #34459, @kyliau can you confirm? I think you would have to do a little extra work to get visitReference to be called, since that change parses an attribute and not a reference, but you could add a call to visitReference in ExpressionVisitor#visitAttr or parse the reference where the attribute is.

I recently read the code, and my solution is to add the reference to the array targetReferences before reporting the error on line 596.

I think this would work, but we will have to get a review from the compiler team to make sure it is okay. My only worry is that this would break the typings of the ReferenceAst because the value of the created reference AST would be null (since there is no matching directive to reference), so this might cause some trouble if the reference is used later in the template (but if an error is reported, I don't know if this matters).

yes, @ayazhafiz is right. I did the work in #34459 to partially address the problem of incomplete template AST. The ideal solution here is to visit AttrAst, create ReferenceAst, then visit it.
However, in order to get hold of the directives that apply to an Element, you have to pass the ElementAst to visitReference() as well. This can be done through the context (second parameter).
Bear in mind that it is insufficient to provide "exportAs" as the sole result set, as was done here. Other symbols that are in scope are valid candidates too.

@kyliau What are the other symbols, can you give me an example? When I input others, it will report the error no directive with "exportAs"

I think it's better to add a new referenceAttributeValueCompletions here.

yes, @ayazhafiz is right. I did the work in #34459 to partially address the problem of incomplete template AST. The ideal solution here is to visit AttrAst, create ReferenceAst, then visit it.

This is the new implementation, if need, I can change to the way as @kyliau said above.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}