Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.8] bpo-36974: separate vectorcall functions for each calling convention (GH-13781) #14782
+372
−101
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
Jul 15, 2019
bedevere-bot
added
the
awaiting review
label
Jul 15, 2019
This comment has been minimized.
This comment has been minimized.
|
I will run pyperformance today to confirm if this fixes the regression. Thanks for the PR @jdemeyer! |
rhettinger
self-assigned this
Jul 23, 2019
This comment has been minimized.
This comment has been minimized.
|
I can confirm this fixes the performance regression. Please apply this backport. |
rhettinger
approved these changes
Jul 23, 2019
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
Jul 23, 2019
ambv
merged commit bf8e82f
into
python:3.8
Jul 23, 2019
6 checks passed
bedevere/maintenance-branch-pr
Valid maintenance branch PR title.
bedevere/news
News entry found in Misc/NEWS.d
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jul 23, 2019
|
@ambv: Please replace |
bedevere-bot
removed
the
awaiting merge
label
Jul 23, 2019
This comment has been minimized.
This comment has been minimized.
|
One day I'll remember to replace # with GH-. It will be a glorious day. |
This comment has been minimized.
This comment has been minimized.
|
Thanks for fixing this :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jdemeyer commentedJul 15, 2019
•
edited
Backport #13781 (part of the PEP 590 implementation) to 3.8 to fix a performance regression, see bpo-37562.
CC @vstinner @pablogsal @ambv
https://bugs.python.org/issue36974