Sitelet https://web.archive.org/web/20210222101159/https://github.com/octobox/octobox/pull/1943
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round icons #1943

Merged
merged 3 commits into from Jul 17, 2019
Merged

Round icons #1943

merged 3 commits into from Jul 17, 2019

Conversation

@BenJam
Copy link
Contributor

@BenJam BenJam commented Jul 17, 2019

Rounds icons for Android, iOS, MS and PWA's. Closes #1916

BenJam added 3 commits Jul 17, 2019
@BenJam
Copy link
Contributor Author

@BenJam BenJam commented Jul 17, 2019

I had a bit of fun with imagemagik :) Please double check I didn't hash up some rando usage of the icon, I tried to cover bases with rounded vs. flat versions but i may have missed something.

@andrew
andrew approved these changes Jul 17, 2019
Copy link
Member

@andrew andrew left a comment

LGTM, I like having the favicon the same as everything else too 👍

@andrew andrew merged commit 1f01701 into master Jul 17, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@andrew andrew deleted the rounded-icons branch Jul 17, 2019
andrew added a commit that referenced this pull request Jul 22, 2019
* master: (40 commits)
  Bump fugit from 1.2.2 to 1.3.0 (#1947)
  Bump rake from 12.3.2 to 12.3.3 (#1946)
  wrap threads in card so that sticky header stays in place on mobile 
(#1944)
  Add draft state to the API (#1945)
  Round icons (#1943)
  Bump oj from 3.7.12 to 3.8.0 (#1942)
  Bump rubocop from 0.72.0 to 0.73.0 (#1941)
  Swallow internal server errors from Octokit when syncing review 
comments (#1939)
  Only download subjects for a notification if the user is present 
(#1937)
  Bump pagy from 3.3.2 to 3.4.0 (#1936)
  Allow custom port to be set for postgres OCTOBOX_DATABASE_PASSWORD 
(#1934)
  Bump hashdiff from 0.4.0 to 1.0.0 (#1935)
  Bump pg_search from 2.2.0 to 2.3.0 (#1932)
  Bump hirefire-resource from 0.7.1 to 0.7.2 (#1931)
  Bump get_process_mem from 0.2.3 to 0.2.4 (#1921)
  Bump bindex from 0.7.0 to 0.8.1 (#1923)
  Bump puma from 4.0.0 to 4.0.1 (#1930)
  Return empty array if skipping downloading reviews  (#1928)
  Add the 'Organization members' permission for GitHub App (#1927)
  More nil checks before downloading reviews (#1926)
  ...
coreyja added a commit to coreyja/octobox that referenced this pull request Jul 27, 2019
* upstream/master: (72 commits)
  Handle a few more edge-case review errors  (octobox#1953)
  Bump pagy from 3.4.0 to 3.4.1 (octobox#1951)
  Bump brakeman from 4.6.0 to 4.6.1 (octobox#1952)
  Bump brakeman from 4.5.1 to 4.6.0 (octobox#1950)
  Bump oj from 3.8.0 to 3.8.1 (octobox#1949)
  Fix PgSearch deprecation warning (octobox#1948)
  Bump fugit from 1.2.2 to 1.3.0 (octobox#1947)
  Bump rake from 12.3.2 to 12.3.3 (octobox#1946)
  wrap threads in card so that sticky header stays in place on mobile (octobox#1944)
  Add draft state to the API (octobox#1945)
  Round icons (octobox#1943)
  Bump oj from 3.7.12 to 3.8.0 (octobox#1942)
  Bump rubocop from 0.72.0 to 0.73.0 (octobox#1941)
  Swallow internal server errors from Octokit when syncing review comments (octobox#1939)
  Only download subjects for a notification if the user is present (octobox#1937)
  Bump pagy from 3.3.2 to 3.4.0 (octobox#1936)
  Allow custom port to be set for postgres OCTOBOX_DATABASE_PASSWORD (octobox#1934)
  Bump hashdiff from 0.4.0 to 1.0.0 (octobox#1935)
  Bump pg_search from 2.2.0 to 2.3.0 (octobox#1932)
  Bump hirefire-resource from 0.7.1 to 0.7.2 (octobox#1931)
  ...

# Conflicts:
#	Gemfile.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants