fix(bazel): only providing stamping information if the --stamp flag is used - #39392
Closed
josephperrott wants to merge 1 commit into
Closed
josephperrott wants to merge 1 commit into
josephperrott wants to merge 1 commit into
Conversation
IgorMinar
approved these changes
Oct 22, 2020
IgorMinar
left a comment
Contributor
There was a problem hiding this comment.
LGTM assuming that the CI is happy as well.
josephperrott
force-pushed
the
more-remote-things
branch
2 times, most recently
from
October 22, 2020 22:18
7e58934 to
a4d86c5
Compare
josephperrott
marked this pull request as ready for review
October 23, 2020 16:24
…s used Previously the volatile status file was always provided to the ng_rollup action which prevented it from being cacheable remotely. This change to only provide this file as an input when the --stamp flag is used will allow for the action to be remotely cached and prevent needing to run the action on every CI run.
josephperrott
force-pushed
the
more-remote-things
branch
from
October 23, 2020 18:25
a4d86c5 to
02b54fa
Compare
alxhub
pushed a commit
that referenced
this pull request
Oct 23, 2020
…s used (#39392) Previously the volatile status file was always provided to the ng_rollup action which prevented it from being cacheable remotely. This change to only provide this file as an input when the --stamp flag is used will allow for the action to be remotely cached and prevent needing to run the action on every CI run. PR Close #39392
alxhub
pushed a commit
that referenced
this pull request
Oct 23, 2020
…s used (#39392) Previously the volatile status file was always provided to the ng_rollup action which prevented it from being cacheable remotely. This change to only provide this file as an input when the --stamp flag is used will allow for the action to be remotely cached and prevent needing to run the action on every CI run. PR Close #39392
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the volatile status file was always provided to the ng_rollup
action which prevented it from being cacheable remotely. This change to
only provide this file as an input when the --stamp flag is used will allow
for the action to be remotely cached and prevent needing to run the action
on every CI run.