Sitelet https://github.com/angular/angular/pull/39121
Skip to content

feat(language-service): Add module name to directive quick info - #39121

Closed
atscott wants to merge 1 commit into
angular:masterfrom
atscott:quickinfomodule
Closed

atscott wants to merge 1 commit into
angular:masterfrom
atscott:quickinfomodule

Conversation

@atscott

@atscott atscott commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

Add module name to quick info for directives

@atscott atscott added action: review The PR is still awaiting reviews from at least one requested reviewer area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release labels Oct 5, 2020
@atscott
atscott requested a review from kyliau October 5, 2020 22:03
@atscott atscott self-assigned this Oct 5, 2020
@ngbot ngbot Bot modified the milestone: needsTriage Oct 5, 2020

@kyliau kyliau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wohoo, this is awesome! =D

Comment thread packages/language-service/ivy/quick_info.ts Outdated
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Oct 6, 2020
@atscott atscott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 6, 2020
This commit adds the module name as the `containerName` to the quick info
for directives.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants