Sitelet https://github.com/angular/angular/pull/38920
Skip to content

revert: feat(router): better warning message when a router outlet has not been instantiated - #38920

Closed
marleypowell wants to merge 1 commit into
angular:masterfrom
marleypowell:router-warning-rollback
Closed

revert: feat(router): better warning message when a router outlet has not been instantiated#38920
marleypowell wants to merge 1 commit into
angular:masterfrom
marleypowell:router-warning-rollback

Conversation

@marleypowell

@marleypowell marleypowell commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe: Revert Changes

What is the current behavior?

The warning that was added created more confusion than it solved and also warned for valid use-cases.

Issue Number: #38804, #38804 (comment)

What is the new behavior?

Removed the warning message so it is no longer logged.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove
pullapprove Bot requested a review from atscott September 21, 2020 12:46
@atscott

atscott commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Hi @marleypowell, thanks for the PR. Could you amend the commit message to be “revert: feat(router): better warning message when a router outlet has not been instantiated” and add “this reverts commit 1609815“ to the top line of the body? This would have been the commit message generated by “git revert 1609815743323f17aa19309af32dd3af74bbfb17“ but we can do it now. The change otherwise LGTM.

@atscott atscott added area: router target: patch This PR is targeted for the next patch release labels Sep 21, 2020
@ngbot ngbot Bot modified the milestone: needsTriage Sep 21, 2020
@atscott atscott added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 21, 2020
@marleypowell
revert: feat(router): better warning message when a router outlet has…
4524365 
… not been instantiated

This reverts commit [1609815].
The warning that was added created more confusion than it solved and also warned for valid use-cases.
@marleypowell
marleypowell force-pushed the router-warning-rollback branch from c7ef054 to 4524365 Compare September 21, 2020 15:13
@marleypowell marleypowell changed the title refactor(router): reverted a commit that added a warning message when a router outlet has not been instantiated revert: feat(router): better warning message when a router outlet has not been instantiated Sep 21, 2020
@marleypowell

marleypowell commented Sep 21, 2020

Copy link
Copy Markdown
Contributor Author

Hi @marleypowell, thanks for the PR. Could you amend the commit message to be “revert: feat(router): better warning message when a router outlet has not been instantiated” and add “this reverts commit 1609815“ to the top line of the body? This would have been the commit message generated by “git revert 1609815 but we can do it now. The change otherwise LGTM.

I've pushed the changes that you've pointed out...

@atscott atscott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 21, 2020
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Sep 21, 2020
@mhevery mhevery added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Sep 21, 2020
@mhevery mhevery closed this in e498ea9 Sep 21, 2020
@atscott atscott mentioned this pull request Sep 21, 2020
Closed
@mhevery mhevery added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Sep 21, 2020
mhevery pushed a commit that referenced this pull request Sep 21, 2020
@marleypowell @mhevery
revert: feat(router): better warning message when a router outlet has…
04d0aa6 
… not been instantiated (#38920)

This reverts commit [1609815].
The warning that was added created more confusion than it solved and also warned for valid use-cases.

PR Close #38920
@marleypowell
marleypowell deleted the router-warning-rollback branch September 22, 2020 06:52
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Oct 23, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: router cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@marleypowell @atscott @mhevery @googlebot