fix: Tolerate missing directories when formatting from stdin - #1848
Merged
Merged
Conversation
When formatting code passed via stdin, and using `--stdin-path`, the path passed may not exist. This is the case when using CSharpier as a [jj] fix tool: Commits are not checked out, so the directory containing the file being formatted may not actually exist on disk. When this happened, CSharpier was throwing a DirectoryNotFoundException from FindForDirectoryName in CSharpierConfigParser. Instead, we can predict this exception and check for configuration in the parent directory, until we find one that does exist. jj: https://jj-vcs.dev
belav
approved these changes
Apr 17, 2026
belav
left a comment
Owner
There was a problem hiding this comment.
Looks good, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When formatting code passed via stdin, and using
--stdin-path, the path passed may not exist. This is the case when using CSharpier as a jj fix tool: Commits are not checked out, so the directory containing the file being formatted may not actually exist on disk.When this happened, CSharpier was throwing a DirectoryNotFoundException from FindForDirectoryName in CSharpierConfigParser.
Instead, we can predict this exception and check for configuration in the parent directory, until we find one that does exist.
Description
Related Issue
Checklist
varthis.