perf: add Doc.Null check to Argument avoids Concat creation - #1706
Merged
Merged
Conversation
TimothyMakkison
force-pushed
the
argument_null
branch
2 times, most recently
from
October 25, 2025 09:49
ba5bc97 to
fc263f1
Compare
TimothyMakkison
force-pushed
the
argument_null
branch
from
October 28, 2025 01:07
fc263f1 to
d66fd7e
Compare
belav
enabled auto-merge (squash)
December 25, 2025 16:22
belav
added a commit
that referenced
this pull request
Dec 31, 2025
) Add check for if `modifiers` are `Doc.Null` to avoid allocating a `Concat` and `Doc[]` ### Benchmarks (timing is inaccurate) #### Before | Method | Mean | Error | StdDev | Median | Gen0 | Gen1 | Allocated | |------------------------------ |---------:|--------:|--------:|---------:|----------:|----------:|----------:| | Default_CodeFormatter_Tests | 131.9 ms | 3.30 ms | 8.86 ms | 128.0 ms | 3000.0000 | 1000.0000 | 34.57 MB | | Default_CodeFormatter_Complex | 261.3 ms | 5.16 ms | 4.03 ms | 261.3 ms | 5000.0000 | 2000.0000 | 53.03 MB | #### After | Method | Mean | Error | StdDev | Median | Gen0 | Gen1 | Allocated | |------------------------------ |---------:|---------:|---------:|---------:|----------:|----------:|----------:| | Default_CodeFormatter_Tests | 189.5 ms | 10.25 ms | 28.05 ms | 195.6 ms | 3000.0000 | 1000.0000 | 34.31 MB | | Default_CodeFormatter_Complex | 264.2 ms | 5.27 ms | 13.97 ms | 260.0 ms | 5000.0000 | 2000.0000 | 52.31 MB | Co-authored-by: Bela VanderVoort <twobitbela@gmail.com>
belav
added a commit
that referenced
this pull request
Feb 20, 2026
) Add check for if `modifiers` are `Doc.Null` to avoid allocating a `Concat` and `Doc[]` ### Benchmarks (timing is inaccurate) #### Before | Method | Mean | Error | StdDev | Median | Gen0 | Gen1 | Allocated | |------------------------------ |---------:|--------:|--------:|---------:|----------:|----------:|----------:| | Default_CodeFormatter_Tests | 131.9 ms | 3.30 ms | 8.86 ms | 128.0 ms | 3000.0000 | 1000.0000 | 34.57 MB | | Default_CodeFormatter_Complex | 261.3 ms | 5.16 ms | 4.03 ms | 261.3 ms | 5000.0000 | 2000.0000 | 53.03 MB | #### After | Method | Mean | Error | StdDev | Median | Gen0 | Gen1 | Allocated | |------------------------------ |---------:|---------:|---------:|---------:|----------:|----------:|----------:| | Default_CodeFormatter_Tests | 189.5 ms | 10.25 ms | 28.05 ms | 195.6 ms | 3000.0000 | 1000.0000 | 34.31 MB | | Default_CodeFormatter_Complex | 264.2 ms | 5.27 ms | 13.97 ms | 260.0 ms | 5000.0000 | 2000.0000 | 52.31 MB | Co-authored-by: Bela VanderVoort <twobitbela@gmail.com>
belav
added a commit
that referenced
this pull request
Mar 12, 2026
) Add check for if `modifiers` are `Doc.Null` to avoid allocating a `Concat` and `Doc[]` ### Benchmarks (timing is inaccurate) #### Before | Method | Mean | Error | StdDev | Median | Gen0 | Gen1 | Allocated | |------------------------------ |---------:|--------:|--------:|---------:|----------:|----------:|----------:| | Default_CodeFormatter_Tests | 131.9 ms | 3.30 ms | 8.86 ms | 128.0 ms | 3000.0000 | 1000.0000 | 34.57 MB | | Default_CodeFormatter_Complex | 261.3 ms | 5.16 ms | 4.03 ms | 261.3 ms | 5000.0000 | 2000.0000 | 53.03 MB | #### After | Method | Mean | Error | StdDev | Median | Gen0 | Gen1 | Allocated | |------------------------------ |---------:|---------:|---------:|---------:|----------:|----------:|----------:| | Default_CodeFormatter_Tests | 189.5 ms | 10.25 ms | 28.05 ms | 195.6 ms | 3000.0000 | 1000.0000 | 34.31 MB | | Default_CodeFormatter_Complex | 264.2 ms | 5.27 ms | 13.97 ms | 260.0 ms | 5000.0000 | 2000.0000 | 52.31 MB | Co-authored-by: Bela VanderVoort <twobitbela@gmail.com>
belav
added a commit
that referenced
this pull request
Apr 4, 2026
) Add check for if `modifiers` are `Doc.Null` to avoid allocating a `Concat` and `Doc[]` ### Benchmarks (timing is inaccurate) #### Before | Method | Mean | Error | StdDev | Median | Gen0 | Gen1 | Allocated | |------------------------------ |---------:|--------:|--------:|---------:|----------:|----------:|----------:| | Default_CodeFormatter_Tests | 131.9 ms | 3.30 ms | 8.86 ms | 128.0 ms | 3000.0000 | 1000.0000 | 34.57 MB | | Default_CodeFormatter_Complex | 261.3 ms | 5.16 ms | 4.03 ms | 261.3 ms | 5000.0000 | 2000.0000 | 53.03 MB | #### After | Method | Mean | Error | StdDev | Median | Gen0 | Gen1 | Allocated | |------------------------------ |---------:|---------:|---------:|---------:|----------:|----------:|----------:| | Default_CodeFormatter_Tests | 189.5 ms | 10.25 ms | 28.05 ms | 195.6 ms | 3000.0000 | 1000.0000 | 34.31 MB | | Default_CodeFormatter_Complex | 264.2 ms | 5.27 ms | 13.97 ms | 260.0 ms | 5000.0000 | 2000.0000 | 52.31 MB | Co-authored-by: Bela VanderVoort <twobitbela@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check for if
modifiersareDoc.Nullto avoid allocating aConcatandDoc[]Benchmarks (timing is inaccurate)
Before
After