Sitelet https://github.com/angular/components/pull/31657
Skip to content

feat(material/testing): Add 'type' attribute filter and getter to Mat… - #31657

Merged
mmalerba merged 3 commits into
angular:mainfrom
wildcardalice:button-filter-type
Aug 11, 2025
Merged

feat(material/testing): Add 'type' attribute filter and getter to Mat…#31657
mmalerba merged 3 commits into
angular:mainfrom
wildcardalice:button-filter-type

Conversation

@wildcardalice

@wildcardalice wildcardalice commented Aug 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Type attribute reference

This small change is primarily intended to simplify filtering for a submit button in a form.

// Before
MatButtonHarness.with({ selector: '[type="submit"]' });

// After (buttonType avoids conflict with the reserved keyword, type)
MatButtonHarness.with({ buttonType: 'submit' });

@wildcardalice
wildcardalice requested a review from a team as a code owner August 6, 2025 18:40
@wildcardalice
wildcardalice requested review from adolgachev and wagnermaciel and removed request for a team August 6, 2025 18:40
@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: material/testing labels Aug 6, 2025
@wildcardalice
wildcardalice force-pushed the button-filter-type branch 2 times, most recently from d9dce35 to 8d141f1 Compare August 6, 2025 19:42
@wildcardalice
fix(material/testing): Rename MatButtonHarness "type" filter to
b0701ac 
"buttonType" to avoid conflict with the reserved TS keyword
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 11, 2025
@mmalerba
mmalerba merged commit 54d514d into angular:main Aug 11, 2025
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 11, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2025
@wildcardalice
wildcardalice deleted the button-filter-type branch September 11, 2025 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes
@adolgachev adolgachev Awaiting requested review from adolgachev adolgachev was automatically assigned from angular/components-googlers
@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel wagnermaciel was automatically assigned from angular/components-googlers

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: material/testing detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wildcardalice @andrewseguin @mmalerba