fix(material/radio): rendering artifacts at some zoom levels - #31612
Merged
Merged
Conversation
crisbeto
requested review from
adolgachev and
ok7sai
and removed request for
a team
July 29, 2025 07:02
Currently the circle inside the radio button is rendered out as an element with a solid border. Presumably MDC did it this way, because it allows more CSS rules to be combined and it handles high contrast mode automatically. The problem with this approach is that depending on the user's screen and zoom level, there can be rendering artifacts on Windows like a dot in the middle of the radio button. These changes resolve the rendering artifacts by using a background color for the circle and which is overridden to `CanvasText` for high contrast mode. Fixes angular#31466.
crisbeto
force-pushed
the
31466/radio-dot
branch
from
July 29, 2025 14:59
2e8def7 to
0858864
Compare
andrewseguin
approved these changes
Jul 29, 2025
Member
Author
|
The changes were merged into the following branches: main, 20.1.x |
crisbeto
added a commit
that referenced
this pull request
Jul 29, 2025
Currently the circle inside the radio button is rendered out as an element with a solid border. Presumably MDC did it this way, because it allows more CSS rules to be combined and it handles high contrast mode automatically. The problem with this approach is that depending on the user's screen and zoom level, there can be rendering artifacts on Windows like a dot in the middle of the radio button. These changes resolve the rendering artifacts by using a background color for the circle and which is overridden to `CanvasText` for high contrast mode. Fixes #31466. (cherry picked from commit 471d323)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the circle inside the radio button is rendered out as an element with a solid border. Presumably MDC did it this way, because it allows more CSS rules to be combined and it handles high contrast mode automatically. The problem with this approach is that depending on the user's screen and zoom level, there can be rendering artifacts on Windows like a dot in the middle of the radio button.
These changes resolve the rendering artifacts by using a background color for the circle and which is overridden to
CanvasTextfor high contrast mode.Fixes #31466.