feat(material/table): accept undefined sort and paginator - #31269
Merged
Merged
Conversation
rslawik
requested review from
andrewseguin and
ok7sai
and removed request for
a team
May 31, 2025 16:41
Contributor
Author
|
Based on internal testing: I reduced the scope of this change to only accept We can accept the casts or consider making a breaking change as a follow up to either:
Same for the paginator. These are fairly tractable to migrate incrementally, so I can help. But the decision which one should be made by the owner. |
Extend types of the sort and paginator setter to include undefined to avoid `?? null` when using singals (e.g. `viewChild`).
andrewseguin
approved these changes
Jul 15, 2025
rslawik
added a commit
to rslawik/angular-components
that referenced
this pull request
Jul 24, 2025
The initial value for `sort` and `paginator` is `undefined` and since angular#31269 the setter accepts `undefined` too (typically from a signal child query). This change aligns the getter type with the real type and makes it symmetric with the setter.
andrewseguin
pushed a commit
that referenced
this pull request
Jul 29, 2025
The initial value for `sort` and `paginator` is `undefined` and since #31269 the setter accepts `undefined` too (typically from a signal child query). This change aligns the getter type with the real type and makes it symmetric with the setter.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend types of the sort and paginator setter to include undefined to avoid
?? nullwhen using singals (e.g.viewChild).