Sitelet https://github.com/angular/components/pull/30356
Skip to content

fix(material/autocomplete): switch away from animations module - #30356

Merged
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:autocomplete-no-animations
Jan 21, 2025
Merged

crisbeto merged 1 commit into
angular:mainfrom
crisbeto:autocomplete-no-animations

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Switches the autocomplete away from the animations module. The animations are implemented using CSS instead.

Switches the autocomplete away from the animations module. The animations are implemented using CSS instead.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 20, 2025
@crisbeto
crisbeto requested a review from a team as a code owner January 20, 2025 13:28
@crisbeto
crisbeto requested review from amysorto and mmalerba and removed request for a team January 20, 2025 13:28
}
}

// Note: the autocomplete intentionally only implements an enter animation.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to do this, because the autocomplete is quite jumpy on selection at the moment and implementing the exit animation requires some extra code.

@crisbeto
crisbeto requested a review from andrewseguin January 20, 2025 13:29
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 21, 2025
@crisbeto
crisbeto merged commit 013fe04 into angular:main Jan 21, 2025
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: material/autocomplete target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants