Sitelet https://github.com/angular/angular/pull/64506
Skip to content

fix(animations): account for Element.animate exceptions - #64506

Closed
JoostK wants to merge 1 commit into
angular:mainfrom
JoostK:animations/animate-failure
Closed

fix(animations): account for Element.animate exceptions#64506
JoostK wants to merge 1 commit into
angular:mainfrom
JoostK:animations/animate-failure

Conversation

@JoostK

@JoostK JoostK commented Oct 17, 2025

Copy link
Copy Markdown
Member

In certain scenarios Element.animate fails, manifesting in an exception (Firefox) or a null return value (Chromium). The null value is not conform WebIDL but handled gracefully in this commit regardless.

Closes #64486

@JoostK
fix(animations): account for Element.animate exceptions
e88a65d 
In certain scenarios `Element.animate` fails, manifesting in an exception (Firefox)
or a null return value (Chromium). The null value is not conform WebIDL but handled
gracefully in this commit regardless.

Closes angular#64486
@JoostK JoostK added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Oct 17, 2025
@pullapprove
pullapprove Bot requested a review from JeanMeche October 17, 2025 20:16
@angular-robot angular-robot Bot added the area: animations legacy animations package only. Otherwise use area: core. label Oct 17, 2025
@ngbot ngbot Bot added this to the Backlog milestone Oct 17, 2025
@JoostK JoostK mentioned this pull request Oct 17, 2025
Closed
@JeanMeche JeanMeche added the requires: TGP This PR requires a passing TGP before merging is allowed label Oct 17, 2025
@pullapprove pullapprove Bot removed the requires: TGP This PR requires a passing TGP before merging is allowed label Oct 17, 2025
@thePunderWoman thePunderWoman added the action: global presubmit The PR is in need of a google3 global presubmit label Oct 20, 2025
@JeanMeche

JeanMeche commented Oct 21, 2025

Copy link
Copy Markdown
Member

That TGP wasn't passing over the week-end because of the diagnostic issue but it should be fine now

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 21, 2025
@ngbot

ngbot Bot commented Oct 21, 2025

Copy link
Copy Markdown

I see that you just added the action: merge label, but the following checks are still failing:
聽聽聽聽failure status "pullapprove" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@thePunderWoman thePunderWoman removed the action: global presubmit The PR is in need of a google3 global presubmit label Oct 21, 2025
thePunderWoman pushed a commit that referenced this pull request Oct 21, 2025
@JoostK @thePunderWoman
fix(animations): account for Element.animate exceptions (#64506)
bd38cd4 
In certain scenarios `Element.animate` fails, manifesting in an exception (Firefox)
or a null return value (Chromium). The null value is not conform WebIDL but handled
gracefully in this commit regardless.

Closes #64486

PR Close #64506
@thePunderWoman

thePunderWoman commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Nov 21, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: animations legacy animations package only. Otherwise use area: core. target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Element.animate can return null in Chromium browsers

3 participants

@JoostK @JeanMeche @thePunderWoman