fix(core): Prevents early style pruning with leave animations - #64335
Closed
thePunderWoman wants to merge 1 commit into
Closed
thePunderWoman wants to merge 1 commit into
thePunderWoman wants to merge 1 commit into
Conversation
JeanMeche
reviewed
Oct 10, 2025
In some cases, the leave animation stylesheets were getting pruned too early due to the renderer removal happening before the animation function was run. This ensures that while queuing a leave animation, we guarantee the lView is referenced in the leaving animations set. This guarantees the style sheet pruning knows about the animations existing and skips the prune step. fixes: angular#64326
thePunderWoman
force-pushed
the
style-prune-fix
branch
from
October 10, 2025 09:20
d4c0591 to
8dbf130
Compare
AndrewKushnir
approved these changes
Oct 13, 2025
Contributor
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 14, 2025
In some cases, the leave animation stylesheets were getting pruned too early due to the renderer removal happening before the animation function was run. This ensures that while queuing a leave animation, we guarantee the lView is referenced in the leaving animations set. This guarantees the style sheet pruning knows about the animations existing and skips the prune step. fixes: #64326 PR Close #64335
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, the leave animation stylesheets were getting pruned too early due to the renderer removal happening before the animation function was run. This was fine before, when the animation queue didn't exist because the function was called faster. Now with the function being thrown into a queue, we need to ensure the lView is in the leaving animation set earlier so it's present when the DOM Renderer calls through to prune the stylesheet.
fixes: #64326