Sitelet https://github.com/angular/angular/pull/64226
Skip to content

fix(core): ensure missing leave animations don't queue leave animations - #64226

Closed
thePunderWoman wants to merge 1 commit into
angular:mainfrom
thePunderWoman:leave-timing
Closed

fix(core): ensure missing leave animations don't queue leave animations#64226
thePunderWoman wants to merge 1 commit into
angular:mainfrom
thePunderWoman:leave-timing

Conversation

@thePunderWoman

@thePunderWoman thePunderWoman commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

There was a bug in the logic for checking if a leave animation exists for a node. This was affecting timing of nodes with enter animations.

@thePunderWoman
fix(core): ensure missing leave animations don't queue leave animations
6a16dc2 
There was a bug in the logic for checking if a leave animation exists for a node. This was affecting timing of nodes with enter animations.
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Oct 3, 2025
@ngbot ngbot Bot added this to the Backlog milestone Oct 3, 2025
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 3, 2025
@ngbot

ngbot Bot commented Oct 3, 2025

Copy link
Copy Markdown

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending status "pullapprove" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba

mmalerba commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

mmalerba pushed a commit that referenced this pull request Oct 3, 2025
@thePunderWoman @mmalerba
fix(core): ensure missing leave animations don't queue leave animatio…
853ed16 
…ns (#64226)

There was a bug in the logic for checking if a leave animation exists for a node. This was affecting timing of nodes with enter animations.

PR Close #64226
@mmalerba mmalerba closed this in 548ea02 Oct 3, 2025
napulitanfrontend pushed a commit to napulitanfrontend/angular that referenced this pull request Oct 10, 2025
@thePunderWoman csorrentino
fix(core): ensure missing leave animations don't queue leave animatio…
aafaad3 
…ns (angular#64226)

There was a bug in the logic for checking if a leave animation exists for a node. This was affecting timing of nodes with enter animations.

PR Close angular#64226
napulitanfrontend pushed a commit to napulitanfrontend/angular that referenced this pull request Oct 11, 2025
@thePunderWoman csorrentino
fix(core): ensure missing leave animations don't queue leave animatio…
be3e25c 
…ns (angular#64226)

There was a bug in the logic for checking if a leave animation exists for a node. This was affecting timing of nodes with enter animations.

PR Close angular#64226
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Nov 3, 2025

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 3, 2025
@thePunderWoman
thePunderWoman deleted the leave-timing branch August 19, 2026 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@thePunderWoman @mmalerba @AndrewKushnir