Sitelet https://github.com/angular/angular/pull/64142
Skip to content

fix(schematics): skip migration for inputs with 'this' references - #64142

Closed
aparzi wants to merge 1 commit into
angular:mainfrom
aparzi:fix-issue-64112
Closed

aparzi wants to merge 1 commit into
angular:mainfrom
aparzi:fix-issue-64112

Conversation

@aparzi

@aparzi aparzi commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Prevents migration of @input() properties that contain references to 'this' in their initializer functions. This ensures that functions accessing class members via 'this' remain unchanged, preventing potential build errors.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Migration attempts to migrate @input properties with 'this' references, resulting in a build error.

Issue Number: #64112

What is the new behavior?

Migration avoids migrating @input with 'this' references thus avoiding generating errors after migration

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove
pullapprove Bot requested a review from kirjs September 29, 2025 22:09
@JeanMeche
JeanMeche removed the request for review from kirjs September 29, 2025 22:14
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 29, 2025
Prevents migration of @input() properties that contain references to 'this' in their initializer functions. This ensures that functions accessing class members via 'this' remain unchanged, preventing potential build errors.
@angular-robot angular-robot Bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Sep 30, 2025
@ngbot ngbot Bot added this to the Backlog milestone Sep 30, 2025
@aparzi

aparzi commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

@JeanMeche @kirjs
I fixed commit message

@kirjs

kirjs commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

kirjs pushed a commit that referenced this pull request Sep 30, 2025
…4142)

Prevents migration of @input() properties that contain references to 'this' in their initializer functions. This ensures that functions accessing class members via 'this' remain unchanged, preventing potential build errors.

PR Close #64142
@kirjs kirjs closed this in 31bc9e4 Sep 30, 2025
napulitanfrontend pushed a commit to napulitanfrontend/angular that referenced this pull request Oct 10, 2025
…gular#64142)

Prevents migration of @input() properties that contain references to 'this' in their initializer functions. This ensures that functions accessing class members via 'this' remain unchanged, preventing potential build errors.

PR Close angular#64142
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants