fix(core): prevents unintended early termination of leave animations … - #64088
Closed
thePunderWoman wants to merge 1 commit into
Closed
thePunderWoman wants to merge 1 commit into
thePunderWoman wants to merge 1 commit into
Conversation
Contributor
Author
|
I need to add a test for this to prevent regressions. |
thePunderWoman
force-pushed
the
animate-leave-fix
branch
3 times, most recently
from
September 25, 2025 18:29
215bff1 to
2889867
Compare
AndrewKushnir
approved these changes
Sep 25, 2025
…and hoisting The event listeners for animationstart and animationend weren't properly checking whether the animation event fired matched the node we're bound to, since animation events bubble. This resulted in child node animation events bubbling up and causing elements to get prematurely removed. fixes: angular#64084
thePunderWoman
force-pushed
the
animate-leave-fix
branch
from
September 25, 2025 18:53
2889867 to
39505a0
Compare
Contributor
kirjs
pushed a commit
that referenced
this pull request
Sep 25, 2025
…and hoisting (#64088) The event listeners for animationstart and animationend weren't properly checking whether the animation event fired matched the node we're bound to, since animation events bubble. This resulted in child node animation events bubbling up and causing elements to get prematurely removed. fixes: #64084 PR Close #64088
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and hoisting
The event listeners for animationstart and animationend weren't properly checking whether the animation event fired matched the node we're bound to, since animation events bubble. This resulted in child node animation events bubbling up and causing elements to get prematurely removed.
fixes: #64084