Sitelet https://github.com/zkmopro/mopro/commit/a20de856bf207cc704946205ed1030289c4e2f31
Skip to content

Commit a20de85

Browse files
vivianjengvivianjeng
committed
fix: update wasm-pack test command for improved feature handling
- Changed the `wasm-pack test` command in the GitHub Actions workflow to use `--features wasm` instead of `--all-features` for better control over feature selection during testing. - Updated the `.cargo/config.toml` to specify the target for unstable features, enhancing clarity in the build configuration. This update refines the testing process for WebAssembly, ensuring that only the necessary features are included.
1 parent 9158e02 commit a20de85

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎.github/workflows/build-and-test.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ jobs:
601601
echo "Check override chrome version"
602602
google-chrome --version
603603
cd mopro-ffi
604-
wasm-pack test --chrome --chromedriver $CHROMEDRIVER_BIN --headless -- --all-features
604+
wasm-pack test --chrome --chromedriver $CHROMEDRIVER_BIN --headless -- --features wasm
605605
test_halo2_wasm_web:
606606
runs-on: ubuntu-latest
607607
needs:

‎mopro-ffi/.cargo/config.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ CIRCOM_PROVER_TEST_WITNESS = ""
44
[target.wasm32-unknown-unknown]
55
rustflags = ["-C", "target-feature=+atomics,+bulk-memory,+mutable-globals", "-C", "link-arg=--max-memory=4294967296"]
66

7-
[unstable]
7+
[unstable.target.wasm32-unknown-unknown]
88
build-std = ["panic_abort", "std"]

0 commit comments

Comments
 (0)