Sitelet https://github.com/xacrimon/dashmap/issues/326
Skip to content

Covariant ReadOnlyView #326

Description

@conradludgate

ReadOnlyView is currently invariant over <K, V>. I've had at least one person ask me for help with this problem, and that's 1 more than I ever expected.

https://github.com/obi1kenobi/trustfall-rustdoc-adapter/compare/dashmap_issue

In my testing, removing the RwLock from the internals of ReadOnlyView fixes the above linked test case.

However, removing the RwLock requires a re-allocation. conradludgate@5e3afd8

Raising this issue to track whether this cost is acceptable, or if there's another work around, or if this is a "wontfix".

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions