Sitelet https://github.com/v8/v8/commit/cb30b8e1742938dff0a24470f24d649b1664f0c2
Skip to content

Commit cb30b8e

Browse files
joyeecheungV8 LUCI CQ
authored andcommitted
Fix compilation error in platform.h for ASAN
The last two operands of the conditional expression needs to be of the same type to compile. Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#86235}
1 parent 30613b8 commit cb30b8e

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎src/base/platform/platform.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -654,9 +654,9 @@ class V8_BASE_EXPORT Stack {
654654
constexpr size_t kAsanRealFrameOffsetBytes = 32;
655655
void* real_frame = __asan_addr_is_in_fake_stack(
656656
__asan_get_current_fake_stack(), slot, nullptr, nullptr);
657-
return real_frame
658-
? (static_cast<char*>(real_frame) + kAsanRealFrameOffsetBytes)
659-
: slot;
657+
return real_frame ? StackSlot(static_cast<char*>(real_frame) +
658+
kAsanRealFrameOffsetBytes)
659+
: slot;
660660
#endif // V8_USE_ADDRESS_SANITIZER
661661
return slot;
662662
}

0 commit comments

Comments
 (0)