Sitelet https://github.com/unoplatform/uno/issues/25015
Skip to content

Re-sync the InfoBar, TreeView and RatingControl fallback styles with MUX 2.5.1 #25015

Description

@MartinZikmund

What would you like to be added? 💡

Uno.UI ships WinUI 2 "v1" copies of these styles, used when XamlControlsResources is not merged:

  • Controls/InfoBar/InfoBar_v1.xaml
  • InfoBar_themeresources_v1.xaml
  • Controls/TreeView/TreeViewItem_v1.xaml
  • TreeView_themeresources_v1.xaml
  • RatingControl_v1.xaml
  • RatingControl_themeresources_v1.xaml

Replace them with the MUX winui3/release/2.5.1 versions, the same ones Uno.UI.FluentTheme/Resources/PriorityDefault already carries, or drop the fallback.

Why is this needed? 🤔

The v1 copies differ a lot from 2.5.1 (InfoBar_v1 differs on 185 of 186 lines):

  • InfoBar severity brushes are hard-coded (#FDE7E9/#FFF4CE/#DFF6DD/#F2F2F2) instead of SystemFillColor*BackgroundBrush.
  • InfoBarBorderThickness is 0 instead of 1.
  • MUX_TreeViewItemStyle is BasedOn ListViewItemExpanded.

Apps without XamlControlsResources therefore get a look WinUI doesn't produce.

Renderer 🎨

  • Skia

For which platforms 📱💻🖥️

All Skia targets

Anything else we need to know? 💬

Follow-up from #21513 (verbatim WinUI Generic.xaml), which deliberately left this out of scope. Compare against winui3/release/2.5.1 in microsoft-ui-xaml (src/controls/dev/...).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/themingCategorizes an issue or PR as relevant to the Theming (Dark, Light, High Contrast)difficulty/medium 🤔Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUIkind/enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions