Commit 1a5a53d
[Loglens] Add overrideFatalWithError flag to LoglensAppender
**Problem**: There is an inconsistency in the way a `FileAppender` and a `LoglensHandler` produce levels for log records.
- LoglensHandler and LoglensFormatter use the `java.util.logging` package to build log records and transform them to `com.twitter.logging`, where the level `ERROR`/`SEVERE` is enumerated to be equivalent to level `FATAL`.
- Conversely, a FileAppender uses the `ch.qos.logback` package to produce records, where events with level `ERROR` are not transformed, and are written directly.
**Solution**: Add a flag for users to include in their `logback.xml` file to optionally override `FATAL` logs with the `ERROR` level, so that records sent to file and those sent to ClickHouse are consistent.
Differential Revision: https://phabricator.twitter.biz/D12506231 parent 33effb4 commit 1a5a53d
1 file changed
Lines changed: 9 additions & 4 deletions
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
| 21 | + | |
21 | 22 | | |
22 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
23 | 27 | | |
24 | 28 | | |
25 | 29 | | |
| |||
125 | 129 | | |
126 | 130 | | |
127 | 131 | | |
128 | | - | |
| 132 | + | |
129 | 133 | | |
130 | 134 | | |
131 | 135 | | |
132 | 136 | | |
133 | 137 | | |
134 | 138 | | |
135 | | - | |
| 139 | + | |
| 140 | + | |
136 | 141 | | |
137 | 142 | | |
138 | 143 | | |
| |||
0 commit comments