Sitelet https://github.com/socketio/engine.io-parser/compare/ebf6e8c...412bcc4
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io-parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ebf6e8c
Choose a base ref
...
head repository: socketio/engine.io-parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 412bcc4
Choose a head ref
  • 15 commits
  • 9 files changed
  • 2 contributors

Commits on Sep 8, 2020

  1. docs: update README

    darrachequesne committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    01df755 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. fix: use a terser-compatible representation of the separator

    By default, terser (the mangler used by webpack) will replace the '\x1e'
    by an unreadable character in the optimized output.
    
    One solution would be to use the 'ascii_only' option:
    
    ```
    module.exports = {
      optimization: {
        minimize: true,
        minimizer: [
          new TerserPlugin({
            terserOptions: {
              output: {
                ascii_only: true
              }
            }
          })
        ]
      }
    };
    ```
    
    But it would require anyone who tries to bundle the engine.io client to
    use this plugin, so we'll rather use String.fromCharCode().
    
    Note: String.fromCharCode(30) === '\u001e' === '\x1e'
    darrachequesne committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    886f9ea View commit details
    Browse the repository at this point in the history
  2. chore(release): 4.0.1

    darrachequesne committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    851c117 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. docs(changelog): include changelog for release 2.2.1

    Merged from the 2.2.x branch.
    darrachequesne committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    ea8804e View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. ci: migrate to GitHub Actions

    Due to the recent changes to the Travis CI platform (see [1]), we will
    now use GitHub Actions to run the tests.
    
    Reference: https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-nodejs
    
    [1]: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
    darrachequesne committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    f5bdf6c View commit details
    Browse the repository at this point in the history
  2. docs: update CI badge

    [skip ci]
    darrachequesne committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    683fc1d View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2020

  1. ci: update configuration for GitHub Actions

    The specific cron hour is meant to prevent concurrent usage of the
    Sauce Labs account.
    darrachequesne committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    b26993e View commit details
    Browse the repository at this point in the history
  2. fix: add base64-arraybuffer as prod dependency

    The dependency was previously only listed as dev dependency, so that it
    was not included when installing the server (the "engine.io" package,
    which does not require it) and was explicitly included by the client
    (the "engine.io-client" package, which needs it for the browser build).
    
    But it failed with yarn v2, due to its stricter package boundaries:
    
    > ERROR in ../../../.yarn/cache/engine.io-parser-npm-4.0.1-6bdb879e8a-3b71ef8b5a.zip/node_modules/engine.io-parser/lib/decodePacket.browser.js 7:18-47
    > Module not found: Error: engine.io-parser tried to access base64-arraybuffer, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.
    
    > Required package: base64-arraybuffer (via "base64-arraybuffer")
    > Required by: engine.io-parser@npm:4.0.1 (via xxx/.yarn/cache/engine.io-parser-npm-4.0.1-6bdb879e8a-3b71ef8b5a.zip/node_modules/engine.io-parser/lib/)
    
    Related:
    
    - https://dev.to/arcanis/introducing-yarn-2-4eh1#strict-package-boundaries
    - #116
    darrachequesne committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    2ccdeb2 View commit details
    Browse the repository at this point in the history
  3. chore(release): 4.0.2

    darrachequesne committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    88799da View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. chore: bump y18n from 4.0.0 to 4.0.1 (#118)

    Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
    - [Release notes](https://github.com/yargs/y18n/releases)
    - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/yargs/y18n/commits)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Apr 1, 2021
    Configuration menu
    Copy the full SHA
    129094f View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. chore: bump elliptic from 6.5.3 to 6.5.4 (#117)

    Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
    - [Release notes](https://github.com/indutny/elliptic/releases)
    - [Commits](indutny/elliptic@v6.5.3...v6.5.4)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jun 11, 2021
    Configuration menu
    Copy the full SHA
    6ab8af0 View commit details
    Browse the repository at this point in the history
  2. chore: bump browserslist from 4.12.0 to 4.16.6 (#119)

    Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.12.0 to 4.16.6.
    - [Release notes](https://github.com/browserslist/browserslist/releases)
    - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
    - [Commits](browserslist/browserslist@4.12.0...4.16.6)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jun 11, 2021
    Configuration menu
    Copy the full SHA
    8b4dcfc View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. chore: bump path-parse from 1.0.6 to 1.0.7 (#120)

    Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
    - [Release notes](https://github.com/jbgutierrez/path-parse/releases)
    - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)
    
    ---
    updated-dependencies:
    - dependency-name: path-parse
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 29, 2021
    Configuration menu
    Copy the full SHA
    6dfab69 View commit details
    Browse the repository at this point in the history
  2. fix: respect the offset and length of TypedArray objects

    The parser now returns the TypedArray object instead of the underlying
    array buffer, so its offset and length are now taken in account (which
    is the behavior of the classic WebSocket implementation).
    
    Notes:
    
    - this was already the case for the Node.js implementation
    
    - in v3, the TypedArray object was always converted to an array buffer
    because a byte was added at the beginning ("message" type)
    
    - we could also have used "data.slice().buffer", but it would have
    resulted in the copy of the buffer
    
    Related:
    
    - #122
    - socketio/engine.io-client#677
    darrachequesne committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    6d7dd76 View commit details
    Browse the repository at this point in the history
  3. chore(release): 4.0.3

    darrachequesne committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    412bcc4 View commit details
    Browse the repository at this point in the history
Loading