Sitelet https://github.com/phpredis/phpredis/commit/bebd398c
Skip to content

Commit bebd398

Browse files
WIP: Update stubs so the tests pass in strict mode
These changes allow the PHP 8 unit tests to pass even when zpp strict mode is enabled. I'm not exactly sure which setting causes the issue, but without these changes I get many `zpp` errors if I run the tests inside of a PHP build tree.
1 parent 19bb553 commit bebd398

6 files changed

Lines changed: 249 additions & 196 deletions

File tree

‎redis.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3434,7 +3434,7 @@ generic_scan_cmd(INTERNAL_FUNCTION_PARAMETERS, REDIS_SCAN_TYPE type) {
34343434
if(type != TYPE_SCAN) {
34353435
// Requires a key
34363436
if(zend_parse_method_parameters(ZEND_NUM_ARGS(), getThis(),
3437-
"Osz/|s!l", &object, redis_ce, &key,
3437+
"Os!z/|s!l", &object, redis_ce, &key,
34383438
&key_len, &z_iter, &pattern,
34393439
&pattern_len, &count)==FAILURE)
34403440
{

0 commit comments

Comments
 (0)