Sitelet https://github.com/phpbench/phpbench/issues/1072
Skip to content

Inconsistent path resolution #1072

Description

@dantleech

Some paths are relative to the config, while others to the CWD:

  "$schema": "vendor/phpbench/phpbench/phpbench.schema.json",
  "runner.path": "../../tests/Benchmark",
  "runner.bootstrap": "phpbench-bootstrap.php",
  "runner.file_pattern": "*Bench.php",
  "storage.xml_storage_path": ".tools/phpbench/data/storage",
  "report.outputs": {
    "html": {
      "renderer": "html",
      "title": "Benchmarks",
      "path": ".tools/phpbench/data/html/index.html"
    }
  }

Suggest to fix this in 2.0 and make them all relative to the config file in which they are defined.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions