Sitelet https://github.com/openstack/python-swiftclient/commit/fe013f741718efb81ffae680617688ddfb8ce9d1
Skip to content

Commit fe013f7

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "trivial: Refactor os_options processing"
2 parents 9c45343 + 825145e commit fe013f7

1 file changed

Lines changed: 20 additions & 19 deletions

File tree

‎swiftclient/service.py‎

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -122,26 +122,27 @@ def process_options(options):
122122

123123
# Specific OpenStack options
124124
options['os_options'] = {
125-
'user_id': options['os_user_id'],
126-
'user_domain_id': options['os_user_domain_id'],
127-
'user_domain_name': options['os_user_domain_name'],
128-
'tenant_id': options['os_tenant_id'],
129-
'tenant_name': options['os_tenant_name'],
130-
'project_id': options['os_project_id'],
131-
'project_name': options['os_project_name'],
132-
'project_domain_id': options['os_project_domain_id'],
133-
'project_domain_name': options['os_project_domain_name'],
134-
'service_type': options['os_service_type'],
135-
'endpoint_type': options['os_endpoint_type'],
136-
'auth_token': options['os_auth_token'],
137-
'object_storage_url': options['os_storage_url'],
138-
'region_name': options['os_region_name'],
139-
'auth_type': options['os_auth_type'],
140-
'application_credential_id':
141-
options['os_application_credential_id'],
142-
'application_credential_secret':
143-
options['os_application_credential_secret'],
125+
opt: options['os_' + opt] for opt in (
126+
'user_id',
127+
'user_domain_id',
128+
'user_domain_name',
129+
'tenant_id',
130+
'tenant_name',
131+
'project_id',
132+
'project_name',
133+
'project_domain_id',
134+
'project_domain_name',
135+
'service_type',
136+
'endpoint_type',
137+
'auth_token',
138+
'region_name',
139+
'auth_type',
140+
'application_credential_id',
141+
'application_credential_secret',
142+
)
144143
}
144+
# this one doesn't follow the same convention
145+
options['os_options']['object_storage_url'] = options['os_storage_url']
145146

146147

147148
def _build_default_global_options():

0 commit comments

Comments
 (0)