open-rpc
diff --git a/‎src/Request.ts‎
Lines changed: 1 addition & 1 deletion b/‎src/Request.ts‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎src/__mocks__/requestData.ts‎
Lines changed: 1 addition & 1 deletion b/‎src/__mocks__/requestData.ts‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎src/transports/TransportRequestManager.test.ts‎
Lines changed: 9 additions & 1 deletion b/‎src/transports/TransportRequestManager.test.ts‎
Lines changed: 9 additions & 1 deletion
diff --git a/‎src/transports/TransportRequestManager.ts‎
Lines changed: 1 addition & 1 deletion b/‎src/transports/TransportRequestManager.ts‎
Lines changed: 1 addition & 1 deletion
@@ -27,7 +27,7 @@ export interface IJSONRPCError {
 
 export interface IJSONRPCResponse {
   jsonrpc: "2.0";
-  id: string | number; // can also be null
+  id?: string | number; // can also be null
   result?: any;
   error?: IJSONRPCError;
 }
 
@@ -36,7 +36,7 @@ export const generateMockNotificationResponse = (result: any, error?: any): req.
   };
 };
 
-export const generateMockErrorResponse = (id: number, data: any): req.IJSONRPCResponse => {
+export const generateMockErrorResponse = (id: number | undefined, data: any): req.IJSONRPCResponse => {
   return {
     id,
     jsonrpc: "2.0",
 
@@ -52,6 +52,14 @@ describe("Transport Request Manager", () => {
     expect(err.message).toContain("Error message");
   });
 
+  it("should error on error response without id", () => {
+    const errPayload = reqData.generateMockErrorResponse(undefined, "haha");
+    delete errPayload.id;
+    const payload = JSON.stringify(errPayload);
+    const err = transportReqMan.resolveResponse(payload, false) as Error;
+    expect(err.message).toContain("Error message");
+  });
+
   it("should error on missing id to resolve and emit error", (done) => {
     transportReqMan.transportEventChannel.on("error", (e) => {
       expect(e.message).toContain("Could not resolve");
@@ -88,7 +96,7 @@ describe("Transport Request Manager", () => {
   });
 
   it("should emit response on response && resolve response", (done) => {
-    const res = reqData.generateMockResponse(1, "hello");
+    const res = reqData.generateMockResponse(1, false);
     // Add request to queue
     const prom = transportReqMan.addRequest({
       request: reqData.generateMockRequest(1, "foo", ["bar"]),
 
@@ -88,7 +88,7 @@ export class TransportRequestManager {
     if (data instanceof Array) {
       payload = data;
     }
-    return payload.every((datum) => (datum.result || datum.error));
+    return payload.every((datum) => (datum.result !== undefined || datum.error !== undefined));
   }
 
   private processResult(payload: any, prom: IRequestPromise) {
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export interface IJSONRPCError {`
`27`	`27`
`28`	`28`	`export interface IJSONRPCResponse {`
`29`	`29`	`jsonrpc: "2.0";`
`30`		`- id: string \| number; // can also be null`
	`30`	`+ id?: string \| number; // can also be null`
`31`	`31`	`result?: any;`
`32`	`32`	`error?: IJSONRPCError;`
`33`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ export class TransportRequestManager {`
`88`	`88`	`if (data instanceof Array) {`
`89`	`89`	`payload = data;`
`90`	`90`	`}`
`91`		`- return payload.every((datum) => (datum.result \|\| datum.error));`
	`91`	`+ return payload.every((datum) => (datum.result !== undefined \|\| datum.error !== undefined));`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`private processResult(payload: any, prom: IRequestPromise) {`