Sitelet https://github.com/npgsql/npgsql/issues/6389
Skip to content

BigIntegerNumericConverter.ReadAsync is missing an early return when everything is already in the buffer #6389

Closed
Bug
#6390
Closed
BigIntegerNumericConverter.ReadAsync is missing an early return when everything is already in the buffer#6389
Bug
#6390
Assignees
vonzshik
Milestone
10.0.2

Description

@vonzshik
vonzshik
opened on Dec 23, 2025

npgsql/src/Npgsql/Internal/Converters/Primitive/NumericConverters.cs

Lines 33 to 37 in 381b0fa

public override ValueTask<BigInteger> ReadAsync(PgReader reader, CancellationToken cancellationToken = default)
{
// If we don't need a read and can read buffered we delegate to our sync read method which won't do IO in such a case.
if (!reader.ShouldBuffer(reader.CurrentRemaining))
Read(reader);

This issue can be reproduced with composites and CommandBehavior.SequentialAccess.

Activity

  1. vonzshik
    added this to the 10.0.2 milestone on Dec 23, 2025
  2. vonzshik
    self-assigned this
    on Dec 23, 2025
  3. vonzshik
    added the
    Bug
    issue type on Dec 23, 2025
  4. vonzshik
    closed this as completedin #6390on Dec 28, 2025
  5. pull
    added a commit that references this issue on Dec 28, 2025

    Fix reading BigInteger with composites (npgsql#6390)

    3c53568
  6. vonzshik
    added 3 commits that reference this issue on Dec 30, 2025

    Fix reading BigInteger with composites (#6390)

    181f247

    Fix reading BigInteger with composites (#6390)

    10c40c7

    Fix reading BigInteger with composites (#6390)

    3e90843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Bug

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions