Sitelet https://github.com/nonstd-lite/string-view-lite/issues/31
Skip to content

-Wshadow fails #31

Description

@mattyclarkson

It would be good if the header was compatible with -Wshadow. It has one error:

nssv_constexpr explicit not_in_view( basic_string_view v ) : v( v ) {}
string_view.hpp:858:68: warning: declaration of ‘v’ shadows a member of ‘nonstd::sv_lite::basic_string_view<CharT, Traits>::not_in_view’ [-Wshadow]

The local argument just needs to be changed:

nssv_constexpr explicit not_in_view( basic_string_view view ) : v( view ) {}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions