Join forces with Diagnostics WG #48

Makes sense to me.

We used to do this -- nodejs/post-mortem members were cc'd and invited to the diagnostics WG meetings (e.g. nodejs/diagnostics#79).

At the time post-mortem was starting the tracing working group had not yet expanded to cover general diagnostics, so it made sense for them to be separate. The groups probably should have merged when the switch to diagnostics happened though.

Ok seems like there is general agreement with the approach. It would be great if the @nodejs/diagnostics team members could joing the next scheduled meeting for the Diagnostics group which is set for: 3-4 EST on Wed Nov 29th.

@mike-kaufman can you make sure to include any items tagged with the diagnostics-agenda Label are included in the agenda.

I agree with @Qard that the groups should have been merged. If post-mortem needs to be kept as a team it should be under the diagnostics WG.

Any objections from @nodejs/post-mortem and/or @nodejs/diagnostics?

+1 from me. I think we should look at migrating open issues over to the Diagnostics repo and making post-mortem a sub-team.

Are there any objections here? I want to start migrating open issues to nodejs/diagnostics next week.

+1

I think that this has been open long enough that we likely would have heard objections if there were going to be any.

There was agreement of all those at the diagnostic session at the summit last week as well.

@mmarchini I think if you don't hear any objections by next week you should be good to go.

Quick question: should I close issues here after migrating them to nodejs/diagnostics?

should I close issues here after migrating them to nodejs/diagnostics?

Yeah, I think that makes sense - we ideally want a single copy of each issue where we concentrate discussion/decisions, vs having multiple copies.

+1 for closing here once there is something equivalent in the Diagnostics repo

@joyeecheung @mhdawson I don't have permission to close issues here :(

Shouldn't nodejs/post-mortem be a subteam of nodejs/diagnostics?

Shouldn't nodejs/post-mortem be a subteam of nodejs/diagnostics?

Ultimately yes (#48 (comment)). It's not at the moment because historically the two have been separate working groups (albeit with enough overlap between members that effectively all post-mortem work is being done under diagnostics and elsewhere in the org which is the main reason for folding post-mortem into diagnostics).

I am actually wondering how many of the issues still open here need to be migrated given the lack of activity. Either the activity is happening elsewhere (in which case there should be another issue/repository elsewhere in the organization) or it has stalled (in which case the issue could be closed with an open invitation to open a new issue over in https://github.com/nodejs/diagnostics?).

All the other open issues here are more than 1 year old, and the discussions seem quite outdated now. If anyone wants to take another stab at them now, it's probably better to open a new issue as the context may have changed a lot since then. I think we should just close them and archive this repo, the previous discussions are useful for archeology but are unlikely to get any new traction as-is.

I'm going through the remaining items and closing them with the following:

Closing due to inactivity. If this work still needs to be tracked, please open a new issue over in https://github.com/nodejs/diagnostics.

The only remaining open issue in this repository is this one 😁. I think the next steps are:

• Open a PR in https://github.com/nodejs/TSC against https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md that merges the Post-mortem WG charter into the Diagnostics WG charter (raised meta: fold the Post-mortem WG into Diagnostics WG TSC#586)
• Reorganisation of the GitHub nodejs/post-mortem team as a subteam of nodejs/diagnostics
• Add a redirect to https://github.com/nodejs/diagnostics
• Update all references to this WG in repositories owned by this WG (https://github.com/nodejs/llnode, https://github.com/nodejs/node-report) to point to the equivalent in https://github.com/nodejs/diagnostics
• Archive this repository

Add a redirect to https://github.com/nodejs/diagnostics

I've updated the description of this repository:

I've put the post-mortem team under the diagnostics team. Should we do the same for https://github.com/orgs/nodejs/teams/post-mortem-admins ?

I've put the post-mortem team under the diagnostics team. Should we do the same for https://github.com/orgs/nodejs/teams/post-mortem-admins ?

I don't see why not. AIUI that team is used by our CI to control access to post-mortem jobs (the node-report one for definite, I can't remember if there were others and am currently locked out of the CI while the security releases are prepped).

We may also want to do a review on the membership like nodejs/diagnostics#217 and put the list of members to the README of the diagnostics repo

That's a fair point. For example, I believe I am a member of this WG but not currently a member of the diagnostics WG.

I agree we don't want to just add people from this WG to the Diagnostics team. I think we need to ask the existing members to confirm they are interested and will be active participants. Since there has not been a post-mortem meeting in a long time I expect that the interested/active parties will mostly already be members of the Diagnostics WG.