Repository navigation
Adopting project workflow to new GitHub features #8554
Description
Activity
I'm +1 for using new PR code review and approval features.
We can also comment the review approval with familiar "LGTM" for time being.
About API: looks like only early-access GitHub GraphQL API allows access to reviews and list of approving collaborators.
I'd agree that approval invalidation on code change is mostly a nice feature, but it might be a bit annoying to have to reapprove after asking that metadata get added to the commit. I'm still +1 though.
Big +1 on using the new tools.
One step closer to automating landing pull requests 🎉 I'm also for this but need to do some reading to better understand how we can use this from github-bot and other places. We're doing testing over at https://github.com/TestOrgPleaseIgnore if someone wants a playground.
Reacted by Gibson FahnestockOf the newly introduced features, the GitHub Projects could be used to better coordinate and track any efforts spanning across multiple issues and pull requests.
Currently many older & open issues remain forgotten and it's hard to keep up with the specific efforts overall progress.
https://help.github.com/articles/tracking-the-progress-of-your-work-with-projects/
Few examples:
- WHATWG URL implementation that has multiple related issues open
- async_wrap, async_hooks
- Major V8 version upgrades (spanning multiple PRs)
Reacted by Josh GavantJust want to reference #8675 here. As much as I like all new features introduced I can't help but feel that jumping on board now would be slightly premature. We still have to figure out scenarios where LGTM/"review approved" (or -1/denied) doesn't get properly zeroed on new commits to PR. It can also stall PR's with "pending reviews". These problems obviously outside of these features too, but I can't help feel like these features should be able to solve use cases like that.
New stuff: review requests for PRs and the search at the very top (Pull requests, Issues).
This is wonderful, as I have 6k+ of unread notifications and sometimes miss the ones that
@mentionme. It should be better now =).Reacted by Rich TrottThis issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.
At the @nodejs/ctc meeting yesterday, @ChALkeR brought up the possibility of using some of the new GitHub tools and features to assist the workflow of landing code in this repository.
I'm particularly interested in whether the GitHub pull request approval feature might help us make things more robust. First, unlike leaving an "LGTM" comment, an approval gets removed if the code changes after the approval is made. I think that's a Good Thing (although others may find it irksome for small fixes perhaps?).
I wonder if approvals might make it reliable to use tools (like I believe @evanlucas has been working on) to generate the metadata for a pull request. I imagine searching comments for the string "LGTM" is imperfect. But it seems likely a list of approving collaborators can be obtained reliably from an API call.
I'm not sure what other features @ChALkeR or others might have in mind too. So, yeah, opening an issue for discussion. @nodejs/collaborators