Repository navigation
test_runner: t.after is never called #51997
Description
Activity
cross referencing to nodejs/undici#2931
In #51371 the example is
import { test } from 'node:test'; import { open } from 'node:fs/promises'; test('test', async (t) => { let filehandle; t.before(async () => { console.log('before'); filehandle = await open('./index.mjs', 'r'); }); t.after(async () => { console.log('after'); await filehandle.close(); }); // await t.test(() => {}); });
This can be simplified to
import { test } from 'node:test'; test('test', async (t) => { t.before(async () => { console.log('before'); }); t.after(async () => { console.log('after'); }); // await t.test(() => {}); });
So running this on node 21.6.2 results in printing only after but not before. In 21.7.0 it does not print anything.
commenting in the test call then in 21.6.2 it prints before and after, but in 21.7.0 only before.- added 2 commits that reference this issue
on Mar 7, 2024 I am currently building node from main branch and want to understand what we should expect. But I wonder what the correct behavior is. Should it really not trigger before and after if there is not test, or should it anyway run before and after if there is no test?!
The documented behavior for
context.before()is:This function is used to create a hook running before subtest of the current test.
The documented behavior for
context.after()is:This function is used to create a hook that runs after the current test finishes.
before(),beforeEach(), andafterEach()only run when there are subtests.after()should run all the time for cleanup purposes (this issue). The reasonbefore()doesn't run all the time is because there are no subtests to run before and it can't run before the test itself that is already running.Actually I have the feeling that before should also run always like after. But I thinks that your revert PR should land asap.
Reacted by Fabian MeyerFeel free to change whatever you want 😄
I would rather prefer continue working on undici ;).
- added a commit that references this issue
on Mar 7, 2024 - added 2 commits that reference this issue
on Mar 7, 2024 - added a commit that references this issue
on Mar 7, 2024
Version
v21.7.0
Platform
n/a
Subsystem
test_runner
What steps will reproduce the bug?
node --test test.mjs
How often does it reproduce? Is there a required condition?
always
What is the expected behavior? Why is that the expected behavior?
No response
What do you see instead?
the test hangs, "Called!" is never printed to the console
Additional information
It could be caused by #51389?