Repository navigation
tests: tools/node_modules is not present in tarball #51145
Description
Activity
Ideally this should have been caught by the https://github.com/nodejs/node/blob/main/.github/workflows/build-tarball.yml workflow in #50684 but it was not 😞.
- name: Copy directories needed for testing run: | cp -r tools/node_modules $TAR_DIR/tools cp -r tools/eslint-rules $TAR_DIR/toolsthis seems to copy things over 🤔 I think either these should be then shipped or should not be needed for tests?
I'm not sure it's reasonable to expect that benchmarks and their tests work with the release tarball.
Well, it's been working since at least nodejs 4.x 😉 I'm happy if
tools/node_modulesis removed in tarball, but there is nopackage-lock.jsonthat allows it to be installed again. This removed part of tarball is about 22MB of disk space.The
tools/eslint-rulesare only 100kB so this can be added to the tarball.- added a commit that references this issue
on Dec 15, 2023 - added a commit that references this issue
on Jan 2, 2024 - added a commit that references this issue
on Mar 25, 2024
Version
No response
Platform
No response
Subsystem
No response
What steps will reproduce the bug?
No response
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
No response
What do you see instead?
In git repository there is
https://github.com/nodejs/node/tree/main/tools/node_modules
in the source tarball, there is nothing there. This breaks at least
https://github.com/nodejs/node/blob/main/benchmark/misc/startup-cli-version.js#L13
Additional information
No response