test-structuredclone-jstransferable is flaky #50260

Activity

1. anonrig

   added

   flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.

   on Oct 18, 2023
2. github-actions

   added

   windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.

   on Oct 18, 2023
3. H4ad commented on Oct 18, 2023

   

   H4ad

   on Oct 18, 2023

   Member

   More actions

   @legendecas Maybe this one is interesting to you.

   14:25:05  failed 2 out of 10
   14:25:05 not ok 922 pummel/test-structuredclone-jstransferable
   14:25:05   ---
   14:25:05   duration_ms: 2662.02700
   14:25:05   severity: fail
   14:25:05   exitcode: 134
   14:25:05   stack: |-
   14:25:05     Administrator: 5680[4512]: C:\workspace\node-compile-windows\node\src\histogram.cc:29: Assertion `(0) == (hdr_init(options.lowest, options.highest, options.figures, &histogram))' failed.
   

   Failing at:

   node/src/histogram.cc

   Lines 24 to 31 in e0bbe56

   	Histogram::Histogram(const Options& options) {
   	hdr_histogram* histogram;
   	CHECK_EQ(0, hdr_init(options.lowest,
   	options.highest,
   	options.figures,
   	&histogram));
   	histogram_.reset(histogram);
   	}
4. nodejs-github-bot

   added a commit that references this issue on Oct 19, 2023

   test: set `test-structuredclone-*` as flaky

   ...

   f9c290f
5. targos

   added a commit that references this issue on Oct 23, 2023

   test: set `test-structuredclone-*` as flaky

   ...

   9bc5ab5
6. targos

   added a commit that references this issue on Nov 11, 2023

   test: set `test-structuredclone-*` as flaky

   ...

   5d4b5ff
7. targos

   added a commit that references this issue on Nov 27, 2023

   test: set `test-structuredclone-*` as flaky

   ...

   83e339d
8. sercher

   added 2 commits that reference this issue on Apr 25, 2024

   test: set `test-structuredclone-*` as flaky

   ...

   60b7b1f

   test: set `test-structuredclone-*` as flaky

   ...

   1ce3721
9. StefanStojanovic commented on Jul 24, 2024

   

   StefanStojanovic

   on Jul 24, 2024

   Contributor

   More actions

   Hey all, I haven't seen this test flaking for some time, so I've run stress test (1000 runs) on it and there were no failures. Is this proof enough that we can remove the flaky mark from it (I'll open a PR after getting a confirmation here), or should something else be done to validate that it is no longer flaky (e.g. more runs in the stress test, or something else)?
10. StefanStojanovic

    added a commit that references this issue on Jul 30, 2024

    test: set test-structuredclone-jstransferable non-flaky

    ...

    f52ef5f
11. nodejs-github-bot

    added a commit that references this issue on Aug 6, 2024

    test: set test-structuredclone-jstransferable non-flaky

    ...

    1f69085
12. nodejs-github-bot

    closed this as completedin #54115on Aug 6, 2024
13. targos

    added a commit that references this issue on Aug 14, 2024

    test: set test-structuredclone-jstransferable non-flaky

    ...

    dafe975
14. targos

    added a commit that references this issue on Sep 21, 2024

    test: set test-structuredclone-jstransferable non-flaky

    ...

    f92305b
15. targos

    added a commit that references this issue on Oct 2, 2024

    test: set test-structuredclone-jstransferable non-flaky

    ...

    d478db7