impossible to use spec test reporter without new

Version

v18.18.1 and v20.8.0

Platform

all

Subsystem

node:test

What steps will reproduce the bug?

const { spec } = require('node:test/reporters');
const { run } = require('node:test');
const path = require('node:path');

run({ files: [path.resolve('./tests/test.js')] })
  .compose(spec)
  .pipe(process.stdout);

Nothing gets printed.

Instead, the following works:

const { spec } = require('node:test/reporters');
const { run } = require('node:test');
const path = require('node:path');

run({ files: [path.resolve('./tests/test.js')] })
  .compose(new spec)
  .pipe(process.stdout);

How often does it reproduce? Is there a required condition?

all the time.

What is the expected behavior? Why is that the expected behavior?

No response

What do you see instead?

No output without new

Additional information

No response

Hello, I have a question.
Should both work(new spec, spec)? Or should only spec work?
Currently, new spec and spec() work, but spec does not work.
I would like to ask if it should work the same way as tap and dot.

While looking for related content, I found that there was an issue that the behavior was different before. (#48112)

I'd like to work on this

I think the reason is spec is a class, but others are *function

I'm not sure this is a bug, you need to call the function, i.e. .compose(spec()). FWIW when using the new keyboard, you are calling the function as a constructor, which is supported but it's no longer necessary since #49184 has landed.

I'm not sure this is a bug, you need to call the function, i.e. .compose(spec()). FWIW when using the new keyboard, you are calling the function as a constructor, which is supported but it's no longer necessary since #49184 has landed.

It's a bug in the form of anything you said is not documented. The only documented thing is .compose(tap), which is incorrect.

node/lib/internal/streams/duplexify.js

Line 86 in 3a648af

const { value, write, final, destroy } = fromAsyncGen(body);

The error starts from here, body is class SpecReporter, but nodejs treats it as a async generator

stream: allow pass stream class to `stream.compose`

Navigation Menu

Repository navigation

impossible to use spec test reporter without new #50176

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

impossible to use spec test reporter without new #50176

Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Activity

pluris commented on Oct 13, 2023

himself65 commented on Oct 13, 2023

himself65 commented on Oct 13, 2023

aduh95 commented on Oct 13, 2023

mcollina commented on Oct 14, 2023

himself65 commented on Oct 14, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions